Re: [PATCH V3 2/3] thermal/drivers/cpu_cooling: Unregister with the policy

2019-06-26 Thread Daniel Lezcano
On 26/06/2019 13:28, Rafael J. Wysocki wrote: > On Wed, Jun 26, 2019 at 12:19 PM Daniel Lezcano > wrote: >> >> On 26/06/2019 11:06, Rafael J. Wysocki wrote: >>> On Wed, Jun 26, 2019 at 8:37 AM Viresh Kumar >>> wrote: On 26-06-19, 08:02, Daniel Lezcano wrote: > On 26/06/2019 04:58,

Re: [PATCH V3 2/3] thermal/drivers/cpu_cooling: Unregister with the policy

2019-06-26 Thread Rafael J. Wysocki
On Wed, Jun 26, 2019 at 12:19 PM Daniel Lezcano wrote: > > On 26/06/2019 11:06, Rafael J. Wysocki wrote: > > On Wed, Jun 26, 2019 at 8:37 AM Viresh Kumar > > wrote: > >> > >> On 26-06-19, 08:02, Daniel Lezcano wrote: > >>> On 26/06/2019 04:58, Viresh Kumar wrote: > On 25-06-19, 13:32, Danie

Re: [PATCH V3 2/3] thermal/drivers/cpu_cooling: Unregister with the policy

2019-06-26 Thread Daniel Lezcano
On 26/06/2019 11:06, Rafael J. Wysocki wrote: > On Wed, Jun 26, 2019 at 8:37 AM Viresh Kumar wrote: >> >> On 26-06-19, 08:02, Daniel Lezcano wrote: >>> On 26/06/2019 04:58, Viresh Kumar wrote: On 25-06-19, 13:32, Daniel Lezcano wrote: > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpu

Re: [PATCH V3 2/3] thermal/drivers/cpu_cooling: Unregister with the policy

2019-06-26 Thread Rafael J. Wysocki
On Wed, Jun 26, 2019 at 8:37 AM Viresh Kumar wrote: > > On 26-06-19, 08:02, Daniel Lezcano wrote: > > On 26/06/2019 04:58, Viresh Kumar wrote: > > > On 25-06-19, 13:32, Daniel Lezcano wrote: > > >> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > > >> index aee024e42618..f07454

Re: [PATCH V3 2/3] thermal/drivers/cpu_cooling: Unregister with the policy

2019-06-25 Thread Viresh Kumar
On 26-06-19, 08:02, Daniel Lezcano wrote: > On 26/06/2019 04:58, Viresh Kumar wrote: > > On 25-06-19, 13:32, Daniel Lezcano wrote: > >> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > >> index aee024e42618..f07454249fbc 100644 > >> --- a/drivers/cpufreq/cpufreq.c > >> +++ b/dri

Re: [PATCH V3 2/3] thermal/drivers/cpu_cooling: Unregister with the policy

2019-06-25 Thread Daniel Lezcano
Hi Viresh, On 26/06/2019 04:58, Viresh Kumar wrote: > On 25-06-19, 13:32, Daniel Lezcano wrote: >> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c >> index aee024e42618..f07454249fbc 100644 >> --- a/drivers/cpufreq/cpufreq.c >> +++ b/drivers/cpufreq/cpufreq.c >> @@ -1379,8 +1

Re: [PATCH V3 2/3] thermal/drivers/cpu_cooling: Unregister with the policy

2019-06-25 Thread Viresh Kumar
On 25-06-19, 13:32, Daniel Lezcano wrote: > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index aee024e42618..f07454249fbc 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -1379,8 +1379,8 @@ static int cpufreq_online(unsigned int cpu) >

[PATCH V3 2/3] thermal/drivers/cpu_cooling: Unregister with the policy

2019-06-25 Thread Daniel Lezcano
Currently the function cpufreq_cooling_register() returns a cooling device pointer which is used back as a pointer to call the function cpufreq_cooling_unregister(). Even if it is correct, it would make sense to not leak the structure inside a cpufreq driver and keep the code thermal code self-enca