Re: [PATCH V3 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-29 Thread Ezequiel Garcia
On 04/29/2015 01:10 AM, Guenter Roeck wrote: > On 04/28/2015 04:28 PM, Ezequiel Garcia wrote: >> >> >> On 04/28/2015 07:51 PM, Ezequiel Garcia wrote: >>> >>> >>> On 04/03/2015 02:05 PM, Andrew Bresticker wrote: Since the heartbeat is statically initialized to its default value, watchdog

Re: [PATCH V3 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-28 Thread Guenter Roeck
On 04/28/2015 04:28 PM, Ezequiel Garcia wrote: On 04/28/2015 07:51 PM, Ezequiel Garcia wrote: On 04/03/2015 02:05 PM, Andrew Bresticker wrote: Since the heartbeat is statically initialized to its default value, watchdog_init_timeout() will never look in the device-tree for a timeout-sec val

Re: [PATCH V3 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-28 Thread Ezequiel Garcia
On 04/28/2015 07:51 PM, Ezequiel Garcia wrote: > > > On 04/03/2015 02:05 PM, Andrew Bresticker wrote: >> Since the heartbeat is statically initialized to its default value, >> watchdog_init_timeout() will never look in the device-tree for a >> timeout-sec value. Instead of statically initializ

Re: [PATCH V3 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-28 Thread Ezequiel Garcia
On 04/03/2015 02:05 PM, Andrew Bresticker wrote: > Since the heartbeat is statically initialized to its default value, > watchdog_init_timeout() will never look in the device-tree for a > timeout-sec value. Instead of statically initializing heartbeat, > fall back to the default timeout value if

Re: [PATCH V3 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-05 Thread Guenter Roeck
On 04/03/2015 10:05 AM, Andrew Bresticker wrote: Since the heartbeat is statically initialized to its default value, watchdog_init_timeout() will never look in the device-tree for a timeout-sec value. Instead of statically initializing heartbeat, fall back to the default timeout value if watchdo

[PATCH V3 1/3] watchdog: imgpdc: Allow timeout to be set in device-tree

2015-04-03 Thread Andrew Bresticker
Since the heartbeat is statically initialized to its default value, watchdog_init_timeout() will never look in the device-tree for a timeout-sec value. Instead of statically initializing heartbeat, fall back to the default timeout value if watchdog_init_timeout() fails. Signed-off-by: Andrew Bres