Re: [PATCH V3 1/2] devres: introduce API "devm_kstrdup"

2014-01-29 Thread Manish Badarkhe
Hi Mark, On Wed, Jan 29, 2014 at 5:10 PM, Mark Brown wrote: > On Wed, Jan 29, 2014 at 04:38:20PM +0530, Manish Badarkhe wrote: >> On Wed, Jan 29, 2014 at 9:48 AM, Joe Perches wrote: > >> >> + buf = devm_kzalloc(dev, size, gfp); > >> > If this is really necessary, please use devm_kmalloc > >>

Re: [PATCH V3 1/2] devres: introduce API "devm_kstrdup"

2014-01-29 Thread Mark Brown
On Wed, Jan 29, 2014 at 04:38:20PM +0530, Manish Badarkhe wrote: > On Wed, Jan 29, 2014 at 9:48 AM, Joe Perches wrote: > >> + buf = devm_kzalloc(dev, size, gfp); > > If this is really necessary, please use devm_kmalloc > devm_kzalloc is always better giving zeroed memory locations. > Is the

Re: [PATCH V3 1/2] devres: introduce API "devm_kstrdup"

2014-01-29 Thread Manish Badarkhe
Hi Joe, Thank you for your review. On Wed, Jan 29, 2014 at 9:48 AM, Joe Perches wrote: > On Wed, 2014-01-29 at 09:33 +0530, Manish Badarkhe wrote: >> This patch introduces "devm_kstrdup" API so that the >> device's driver can allocate memory and copy string. > [] >> diff --git a/drivers/base/dev

Re: [PATCH V3 1/2] devres: introduce API "devm_kstrdup"

2014-01-28 Thread Joe Perches
On Wed, 2014-01-29 at 09:33 +0530, Manish Badarkhe wrote: > This patch introduces "devm_kstrdup" API so that the > device's driver can allocate memory and copy string. [] > diff --git a/drivers/base/devres.c b/drivers/base/devres.c [] > @@ -791,6 +791,32 @@ void * devm_kmalloc(struct device *dev, s

[PATCH V3 1/2] devres: introduce API "devm_kstrdup"

2014-01-28 Thread Manish Badarkhe
This patch introduces "devm_kstrdup" API so that the device's driver can allocate memory and copy string. Signed-off-by: Manish Badarkhe --- :100644 100644 545c4de... 6e88a3d... M drivers/base/devres.c :100644 100644 952b010... 8fee649... M include/linux/device.h drivers/base/devres.c | 26