Re: [PATCH V3 1/1] tick: broadcast-hrtimer: Fix a race in bc_set_next

2019-09-26 Thread Eugeniu Rosca
On Thu, Sep 26, 2019 at 03:51:01PM +0200, Balasubramani Vivekanandan wrote: > When a cpu requests broadcasting, before starting the tick broadcast > hrtimer, bc_set_next() checks if the timer callback (bc_handler) is > active using hrtimer_try_to_cancel(). But hrtimer_try_to_cancel() does > not pro

[PATCH V3 1/1] tick: broadcast-hrtimer: Fix a race in bc_set_next

2019-09-26 Thread Balasubramani Vivekanandan
When a cpu requests broadcasting, before starting the tick broadcast hrtimer, bc_set_next() checks if the timer callback (bc_handler) is active using hrtimer_try_to_cancel(). But hrtimer_try_to_cancel() does not provide the required synchronization when the callback is active on other core. The cal

[PATCH V3 1/1] tick: broadcast-hrtimer: Fix a race in bc_set_next

2019-09-26 Thread Balasubramani Vivekanandan
> I which way is this backtrace giving any useful information about the problem? The intention of me including the callstack was to help anyone notice this commit while searching using the prints from the callstack. I have removed it if it is creating noise. > Interesting. You claim authorship