Re: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001

2020-11-03 Thread Christoph Hellwig
On Tue, Nov 03, 2020 at 02:21:16AM +, Gloria Tsai wrote: > When host issue shutdown + D3hot in suspend, NVMe drive might have > chance choosing wrong pointer which has already been used by GC then > cause over program. > Do GC before shutdown -> delete IO Q -> shutdown from host -> breakup GC -

RE: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001

2020-11-02 Thread Gloria Tsai
Sagi Grimberg ; linux-n...@lists.infradead.org; linux-kernel@vger.kernel.org; Gloria Tsai ; jongpil19.j...@samsung.com; jongheony@samsung.com; dj54.s...@samsung.com Subject: Re: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001 This message was sent from outside of the company. P

Re: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001

2020-11-02 Thread Christoph Hellwig
On Thu, Oct 29, 2020 at 03:55:29PM +0100, Christoph Hellwig wrote: > I'm still worried about this. > > If power state based suspend does always work despite a HMB and is > preferred for the specific Google board we should have purely a DMI > based quirk for the board independent of the NVMe contro

Re: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001

2020-10-29 Thread Christoph Hellwig
I'm still worried about this. If power state based suspend does always work despite a HMB and is preferred for the specific Google board we should have purely a DMI based quirk for the board independent of the NVMe controller used with it. But if these LiteON devices can't properly handle nvme_de

Re: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001

2020-10-29 Thread Keith Busch
On Thu, Oct 29, 2020 at 11:33:06AM +0900, Keith Busch wrote: > On Thu, Oct 29, 2020 at 02:20:27AM +, Gloria Tsai wrote: > > Corrected the description of this bug that SSD will not do GC after > > receiving shutdown cmd. > > Do GC before shutdown -> delete IO Q -> shutdown from host -> breakup

RE: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001

2020-10-29 Thread Gloria Tsai
nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001 This message was sent from outside of the company. Please do not click links or open attachments unless you recognize the source of this email and know the content is safe. On Thu, Oct 29, 2020 at 11:33:06AM +0900, Keith Busch

Re: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001

2020-10-28 Thread Keith Busch
On Thu, Oct 29, 2020 at 02:20:27AM +, Gloria Tsai wrote: > Corrected the description of this bug that SSD will not do GC after receiving > shutdown cmd. > Do GC before shutdown -> delete IO Q -> shutdown from host -> breakup GC -> > D3hot -> enter PS4 -> have a chance swap block -> use wrong

RE: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001

2020-10-28 Thread Gloria Tsai
Axboe ; Christoph Hellwig ; Sagi Grimberg ; linux-n...@lists.infradead.org; linux-kernel@vger.kernel.org; Gloria Tsai ; jongpil19.j...@samsung.com; jongheony@samsung.com; dj54.s...@samsung.com Subject: Re: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001 This me

Re: [PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001

2020-10-28 Thread Christoph Hellwig
On Wed, Oct 28, 2020 at 06:14:21PM +0900, Jongpil Jung wrote: > LiteON(SSSTC) CL1 device running FW 220TQ,22001 has bugs with simple > suspend. > > When NVMe device receive D3hot from host, NVMe firmware will do > garbage collection. While NVMe device do Garbage collection, > firmware has chance t

[PATCH V3 1/1] nvme: Add quirk for LiteON CL1 devices running FW 220TQ,22001

2020-10-28 Thread Jongpil Jung
LiteON(SSSTC) CL1 device running FW 220TQ,22001 has bugs with simple suspend. When NVMe device receive D3hot from host, NVMe firmware will do garbage collection. While NVMe device do Garbage collection, firmware has chance to going incorrect address. In that case, NVMe storage device goes to no de