Re: [PATCH V3 05/12] kernfs: introduce kernfs_node_id

2017-06-19 Thread Tejun Heo
Hello, On Thu, Jun 15, 2017 at 11:17:13AM -0700, Shaohua Li wrote: > +/* represent a kernfs node */ > +struct kernfs_node_id { > + u32 ino; > + u32 generation; > +} __attribute__((packed)); Can we just make it a u64? kernfs cares about the details

Re: [PATCH V3 05/12] kernfs: introduce kernfs_node_id

2017-06-16 Thread kbuild test robot
Hi Shaohua, [auto build test ERROR on block/for-next] [also build test ERROR on v4.12-rc5 next-20170616] [cannot apply to driver-core/driver-core-testing] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/

[PATCH V3 05/12] kernfs: introduce kernfs_node_id

2017-06-15 Thread Shaohua Li
From: Shaohua Li inode number and generation can identify a kernfs node. We are going to export the identification by exportfs operations, so put ino and generation into a separate structure. It's convenient when later patches use the identification. Signed-off-by: Shaohua Li --- fs/kernfs/dir