Re: [PATCH V3] scsi: ufs-debugfs: Add error counters

2020-12-18 Thread Bean Huo
On Fri, 2020-12-18 at 20:34 +0200, Adrian Hunter wrote: > It is OK to pass NULL or error codes as parent dentry to > debugfs_create_... > functions. > > If ufs_debugfs_root is NULL (which won't happen) then the directory > will be > created in debugfs root i.e. /sys/kernel/debug, using the device

Re: [PATCH V3] scsi: ufs-debugfs: Add error counters

2020-12-18 Thread Adrian Hunter
On 18/12/20 5:17 pm, Bean Huo wrote: > On Fri, 2020-12-18 at 14:20 +0200, Adrian Hunter wrote: >> People testing have a need to know how many errors might be occurring >> over time. Add error counters and expose them via debugfs. >> >> A module initcall is used to create a debugfs root directory fo

Re: [PATCH V3] scsi: ufs-debugfs: Add error counters

2020-12-18 Thread Bean Huo
On Fri, 2020-12-18 at 14:20 +0200, Adrian Hunter wrote: > People testing have a need to know how many errors might be occurring > over time. Add error counters and expose them via debugfs. > > A module initcall is used to create a debugfs root directory for > ufshcd-related items. In the case that

[PATCH V3] scsi: ufs-debugfs: Add error counters

2020-12-18 Thread Adrian Hunter
People testing have a need to know how many errors might be occurring over time. Add error counters and expose them via debugfs. A module initcall is used to create a debugfs root directory for ufshcd-related items. In the case that modules are built-in, then initialization is done in link order,