Re: [PATCH V3] cpufreq: Call transition notifier only once for each policy

2019-04-24 Thread Rafael J. Wysocki
On Wed, Apr 24, 2019 at 8:48 AM Viresh Kumar wrote: > > On 22-03-19, 11:49, Viresh Kumar wrote: > > On 21-03-19, 12:45, Peter Zijlstra wrote: > > > On Wed, Mar 20, 2019 at 10:22:23AM +0530, Viresh Kumar wrote: > > > > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > > > > index 65e4559eef2

Re: [PATCH V3] cpufreq: Call transition notifier only once for each policy

2019-04-23 Thread Viresh Kumar
On 22-03-19, 11:49, Viresh Kumar wrote: > On 21-03-19, 12:45, Peter Zijlstra wrote: > > On Wed, Mar 20, 2019 at 10:22:23AM +0530, Viresh Kumar wrote: > > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > > > index 65e4559eef2f..1ac8c710 100644 > > > --- a/arch/x86/kvm/x86.c > > > +++ b/

Re: [PATCH V3] cpufreq: Call transition notifier only once for each policy

2019-03-22 Thread Rafael J. Wysocki
On Fri, Mar 22, 2019 at 7:28 AM Viresh Kumar wrote: > > On 21-03-19, 16:49, Thomas Gleixner wrote: > > On Wed, 20 Mar 2019, Viresh Kumar wrote: > > > > > > diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c > > > index 3fae23834069..b2fe665878f7 100644 > > > --- a/arch/x86/kernel/tsc.c > >

Re: [PATCH V3] cpufreq: Call transition notifier only once for each policy

2019-03-21 Thread Viresh Kumar
On 21-03-19, 16:49, Thomas Gleixner wrote: > On Wed, 20 Mar 2019, Viresh Kumar wrote: > > > > diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c > > index 3fae23834069..b2fe665878f7 100644 > > --- a/arch/x86/kernel/tsc.c > > +++ b/arch/x86/kernel/tsc.c > > @@ -958,10 +958,15 @@ static int t

Re: [PATCH V3] cpufreq: Call transition notifier only once for each policy

2019-03-21 Thread Viresh Kumar
On 21-03-19, 12:45, Peter Zijlstra wrote: > On Wed, Mar 20, 2019 at 10:22:23AM +0530, Viresh Kumar wrote: > > diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c > > index 3fae23834069..b2fe665878f7 100644 > > --- a/arch/x86/kernel/tsc.c > > +++ b/arch/x86/kernel/tsc.c > > @@ -958,10 +958,15

Re: [PATCH V3] cpufreq: Call transition notifier only once for each policy

2019-03-21 Thread Thomas Gleixner
On Wed, 20 Mar 2019, Viresh Kumar wrote: > Currently we call these notifiers once for each CPU of the policy->cpus Nitpick: We call nothing. The notifiers are called > cpumask. It would be more optimal if the notifier can be called only > once and all the relevant information be provided to

Re: [PATCH V3] cpufreq: Call transition notifier only once for each policy

2019-03-21 Thread Peter Zijlstra
On Wed, Mar 20, 2019 at 10:22:23AM +0530, Viresh Kumar wrote: > diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c > index 3fae23834069..b2fe665878f7 100644 > --- a/arch/x86/kernel/tsc.c > +++ b/arch/x86/kernel/tsc.c > @@ -958,10 +958,15 @@ static int time_cpufreq_notifier(struct notifier_b

[PATCH V3] cpufreq: Call transition notifier only once for each policy

2019-03-19 Thread Viresh Kumar
Currently we call these notifiers once for each CPU of the policy->cpus cpumask. It would be more optimal if the notifier can be called only once and all the relevant information be provided to it. Out of the 23 drivers that register for the transition notifiers today, only 4 of them do per-cpu upd