Re: [PATCH V3] block/throttle: Add IO throttled information in blkio.throttle

2012-10-19 Thread Vivek Goyal
On Fri, Oct 19, 2012 at 12:36:00PM -0700, Tejun Heo wrote: > Hello, Vivek. > > On Fri, Oct 19, 2012 at 11:00:11AM -0400, Vivek Goyal wrote: > > > That way we can stick to the usual stats facility. > > > > So how does this help? Because it is a monotonically increasing value > > we can use per cpu

Re: [PATCH V3] block/throttle: Add IO throttled information in blkio.throttle

2012-10-19 Thread Tejun Heo
Hello, Vivek. On Fri, Oct 19, 2012 at 11:00:11AM -0400, Vivek Goyal wrote: > > That way we can stick to the usual stats facility. > > So how does this help? Because it is a monotonically increasing value > we can use per cpu stats without extra locking? Or somthing else? It's generally much simp

Re: [PATCH V3] block/throttle: Add IO throttled information in blkio.throttle

2012-10-19 Thread Vivek Goyal
On Thu, Oct 18, 2012 at 04:24:04PM -0700, Tejun Heo wrote: > Hello, Vivek. > > On Wed, Oct 17, 2012 at 09:49:45AM -0400, Vivek Goyal wrote: > > Can you explain a bit more. Whe do you mean by "total number queued". I > > think throttle.io_queued will total number of bios queued in the cgroup > > at

Re: [PATCH V3] block/throttle: Add IO throttled information in blkio.throttle

2012-10-18 Thread Tejun Heo
Hello, Vivek. On Wed, Oct 17, 2012 at 09:49:45AM -0400, Vivek Goyal wrote: > Can you explain a bit more. Whe do you mean by "total number queued". I > think throttle.io_queued will total number of bios queued in the cgroup > at the time of query. Instead of exposing the number that blk-throttle c

Re: [PATCH V3] block/throttle: Add IO throttled information in blkio.throttle

2012-10-17 Thread Vivek Goyal
On Tue, Oct 16, 2012 at 04:27:06PM -0700, Tejun Heo wrote: [..] > > Changelog from v2: > > Use nr-queued[] of struct throtl_grp for stats instaed of adding new > > blkg_rwstat. > > As I wrote last time, I would prefer exposing the total number queued > to blk-throttle rather than exposing th

Re: [PATCH V3] block/throttle: Add IO throttled information in blkio.throttle

2012-10-16 Thread Tejun Heo
Hello, Robin. On Tue, Oct 09, 2012 at 02:53:45PM +0800, Robin Dong wrote: > Currently, if the IO is throttled by io-throttle, the SA has no idea of > the situation and can't report it to the real application user about Please don't use "SA" in the commit message. Just write it out as "system adm

Re: [PATCH V3] block/throttle: Add IO throttled information in blkio.throttle

2012-10-10 Thread Vivek Goyal
On Tue, Oct 09, 2012 at 02:53:45PM +0800, Robin Dong wrote: > From: Robin Dong > > Currently, if the IO is throttled by io-throttle, the SA has no idea of > the situation and can't report it to the real application user about > that he/she has to do something. So this patch adds a new interface >

[PATCH V3] block/throttle: Add IO throttled information in blkio.throttle

2012-10-08 Thread Robin Dong
From: Robin Dong Currently, if the IO is throttled by io-throttle, the SA has no idea of the situation and can't report it to the real application user about that he/she has to do something. So this patch adds a new interface named blkio.throttle.io_queued which indicates how many IOs are current