Re: [PATCH V2 mmots] fs/hfsplus/wrapper.c: replace shift loop by fls

2014-05-19 Thread Joe Perches
On Tue, 2014-05-20 at 07:02 +0200, Fabian Frederick wrote: > and the winner is ? :) Either works. You're the patch submitter. Pick one. But I'm sure you know I'm not pushing the patch upstream... :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mes

Re: [PATCH V2 mmots] fs/hfsplus/wrapper.c: replace shift loop by fls

2014-05-19 Thread Fabian Frederick
On Mon, 19 May 2014 16:50:05 -0700 Joe Perches wrote: > On Mon, 2014-05-19 at 16:40 -0700, Andrew Morton wrote: > > On Mon, 19 May 2014 16:22:28 -0700 Joe Perches wrote: > > > > > On Mon, 2014-05-19 at 16:09 -0700, Andrew Morton wrote: > > > > On Fri, 16 May 2014 22:38:15 +0200 Fabian Frederick

Re: [PATCH V2 mmots] fs/hfsplus/wrapper.c: replace shift loop by fls

2014-05-19 Thread Joe Perches
On Mon, 2014-05-19 at 16:40 -0700, Andrew Morton wrote: > On Mon, 19 May 2014 16:22:28 -0700 Joe Perches wrote: > > > On Mon, 2014-05-19 at 16:09 -0700, Andrew Morton wrote: > > > On Fri, 16 May 2014 22:38:15 +0200 Fabian Frederick > > > wrote: > > > > Replace while blocksize;shift by fls -1 >

Re: [PATCH V2 mmots] fs/hfsplus/wrapper.c: replace shift loop by fls

2014-05-19 Thread Andrew Morton
On Mon, 19 May 2014 16:22:28 -0700 Joe Perches wrote: > On Mon, 2014-05-19 at 16:09 -0700, Andrew Morton wrote: > > On Fri, 16 May 2014 22:38:15 +0200 Fabian Frederick wrote: > > > Replace while blocksize;shift by fls -1 > [] > > fls() always makes my brain hurt. ilog() is nicer? > > Maybe tak

Re: [PATCH V2 mmots] fs/hfsplus/wrapper.c: replace shift loop by fls

2014-05-19 Thread Joe Perches
On Mon, 2014-05-19 at 16:09 -0700, Andrew Morton wrote: > On Fri, 16 May 2014 22:38:15 +0200 Fabian Frederick wrote: > > Replace while blocksize;shift by fls -1 [] > fls() always makes my brain hurt. ilog() is nicer? Maybe take an aspirin? ilog2(n) is effectively fls(n) - 1 but n can be either

Re: [PATCH V2 mmots] fs/hfsplus/wrapper.c: replace shift loop by fls

2014-05-19 Thread Andrew Morton
On Fri, 16 May 2014 22:38:15 +0200 Fabian Frederick wrote: > Replace while blocksize;shift by fls -1 > > Suggested-By: Joe Perches > Cc: Andrew Morton > Signed-off-by: Fabian Frederick > --- > v2: rebased on top of mmots > compiles without including bitops > > fs/hfsplus/wrapper.c | 4 +

[PATCH V2 mmots] fs/hfsplus/wrapper.c: replace shift loop by fls

2014-05-16 Thread Fabian Frederick
Replace while blocksize;shift by fls -1 Suggested-By: Joe Perches Cc: Andrew Morton Signed-off-by: Fabian Frederick --- v2: rebased on top of mmots compiles without including bitops fs/hfsplus/wrapper.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/hfsplus/wrap