Re: [PATCH V2 3/3] perf: Optimize sched_task() in a context switch

2021-02-22 Thread Namhyung Kim
On Wed, Jan 27, 2021 at 1:41 PM Namhyung Kim wrote: > > Hi, > > On Mon, Jan 18, 2021 at 4:04 PM Namhyung Kim wrote: > > > > Hi Peter and Kan, > > > > On Thu, Dec 10, 2020 at 11:25 PM Peter Zijlstra > > wrote: > > > > > > On Thu, Dec 10, 2020 at 08:52:55AM -0500, Liang, Kan wrote: > > > > > > >

Re: [PATCH V2 3/3] perf: Optimize sched_task() in a context switch

2021-01-26 Thread Namhyung Kim
Hi, On Mon, Jan 18, 2021 at 4:04 PM Namhyung Kim wrote: > > Hi Peter and Kan, > > On Thu, Dec 10, 2020 at 11:25 PM Peter Zijlstra wrote: > > > > On Thu, Dec 10, 2020 at 08:52:55AM -0500, Liang, Kan wrote: > > > > > > > > > On 12/10/2020 2:13 AM, Namhyung Kim wrote: > > > > Hi Peter and Kan, > >

Re: [PATCH V2 3/3] perf: Optimize sched_task() in a context switch

2021-01-17 Thread Namhyung Kim
Hi Peter and Kan, On Thu, Dec 10, 2020 at 11:25 PM Peter Zijlstra wrote: > > On Thu, Dec 10, 2020 at 08:52:55AM -0500, Liang, Kan wrote: > > > > > > On 12/10/2020 2:13 AM, Namhyung Kim wrote: > > > Hi Peter and Kan, > > > > > > How can we move this forward? > > > > Hi Namhyung, > > > > Thanks for

Re: [PATCH V2 3/3] perf: Optimize sched_task() in a context switch

2020-12-10 Thread Peter Zijlstra
On Thu, Dec 10, 2020 at 08:52:55AM -0500, Liang, Kan wrote: > > > On 12/10/2020 2:13 AM, Namhyung Kim wrote: > > Hi Peter and Kan, > > > > How can we move this forward? > > Hi Namhyung, > > Thanks for the test. The changes look good to me. > > Hi Peter, > > Should we resend the patch set for

Re: [PATCH V2 3/3] perf: Optimize sched_task() in a context switch

2020-12-10 Thread Liang, Kan
On 12/10/2020 2:13 AM, Namhyung Kim wrote: Hi Peter and Kan, How can we move this forward? Hi Namhyung, Thanks for the test. The changes look good to me. Hi Peter, Should we resend the patch set for further review? Thanks, Kan Thanks, Namhyung On Fri, Dec 4, 2020 at 4:14 PM Namhyu

Re: [PATCH V2 3/3] perf: Optimize sched_task() in a context switch

2020-12-09 Thread Namhyung Kim
Hi Peter and Kan, How can we move this forward? Thanks, Namhyung On Fri, Dec 4, 2020 at 4:14 PM Namhyung Kim wrote: > > Hi Peter, > > On Wed, Dec 2, 2020 at 2:29 AM Peter Zijlstra wrote: > > > > On Mon, Nov 30, 2020 at 11:38:42AM -0800, kan.li...@linux.intel.com wrote: > > > From: Kan Liang >

Re: [PATCH V2 3/3] perf: Optimize sched_task() in a context switch

2020-12-03 Thread Namhyung Kim
Hi Peter, On Wed, Dec 2, 2020 at 2:29 AM Peter Zijlstra wrote: > > On Mon, Nov 30, 2020 at 11:38:42AM -0800, kan.li...@linux.intel.com wrote: > > From: Kan Liang > > > > Some calls to sched_task() in a context switch can be avoided. For > > example, large PEBS only requires flushing the buffer i

Re: [PATCH V2 3/3] perf: Optimize sched_task() in a context switch

2020-12-02 Thread Namhyung Kim
Hi Peter and Kan, On Tue, Dec 01, 2020 at 06:29:03PM +0100, Peter Zijlstra wrote: > On Mon, Nov 30, 2020 at 11:38:42AM -0800, kan.li...@linux.intel.com wrote: > > From: Kan Liang > > > > Some calls to sched_task() in a context switch can be avoided. For > > example, large PEBS only requires flus

Re: [PATCH V2 3/3] perf: Optimize sched_task() in a context switch

2020-12-02 Thread Peter Zijlstra
On Tue, Dec 01, 2020 at 06:29:03PM +0100, Peter Zijlstra wrote: > +static void context_sched_task(struct perf_cpu_context *cpuctx, > +struct perf_event_context *ctx, > +bool sched_in) > +{ > + struct pmu *pmu = ctx->pmu; > + > + if (cp

Re: [PATCH V2 3/3] perf: Optimize sched_task() in a context switch

2020-12-01 Thread Peter Zijlstra
On Mon, Nov 30, 2020 at 11:38:42AM -0800, kan.li...@linux.intel.com wrote: > From: Kan Liang > > Some calls to sched_task() in a context switch can be avoided. For > example, large PEBS only requires flushing the buffer in context switch > out. The current code still invokes the sched_task() for

[PATCH V2 3/3] perf: Optimize sched_task() in a context switch

2020-11-30 Thread kan . liang
From: Kan Liang Some calls to sched_task() in a context switch can be avoided. For example, large PEBS only requires flushing the buffer in context switch out. The current code still invokes the sched_task() for large PEBS in context switch in. The current code doesn't know and check the states