Re: [PATCH V2 3/3] mfd: wm8994-core: Don't use managed regulator bulk get API

2016-10-26 Thread Lee Jones
On Wed, 26 Oct 2016, Lee Jones wrote: > On Fri, 16 Sep 2016, Viresh Kumar wrote: > > > The kernel WARNs and then crashes today if wm8994_device_init() fails > > after calling devm_regulator_bulk_get(). > > > > That happens because there are multiple devices involved here and the > > order in whi

Re: [PATCH V2 3/3] mfd: wm8994-core: Don't use managed regulator bulk get API

2016-10-26 Thread Lee Jones
On Fri, 16 Sep 2016, Viresh Kumar wrote: > The kernel WARNs and then crashes today if wm8994_device_init() fails > after calling devm_regulator_bulk_get(). > > That happens because there are multiple devices involved here and the > order in which managed resources are freed isn't correct. > > Th

Re: [PATCH V2 3/3] mfd: wm8994-core: Don't use managed regulator bulk get API

2016-09-16 Thread Charles Keepax
On Fri, Sep 16, 2016 at 08:57:00AM +0530, Viresh Kumar wrote: > The kernel WARNs and then crashes today if wm8994_device_init() fails > after calling devm_regulator_bulk_get(). > > That happens because there are multiple devices involved here and the > order in which managed resources are freed is

[PATCH V2 3/3] mfd: wm8994-core: Don't use managed regulator bulk get API

2016-09-15 Thread Viresh Kumar
The kernel WARNs and then crashes today if wm8994_device_init() fails after calling devm_regulator_bulk_get(). That happens because there are multiple devices involved here and the order in which managed resources are freed isn't correct. The regulators are added as children of wm8994->dev. Wher