Re: [PATCH V2 3/3] cpufreq: initialize governor for a new policy under policy->rwsem

2014-03-06 Thread Rafael J. Wysocki
On Thursday, March 06, 2014 10:24:38 AM Viresh Kumar wrote: > On 6 March 2014 09:04, Rafael J. Wysocki wrote: > > I've rebased this one on top of 3.14-rc5 and queued it up for 3.14-rc6. > > > > Please check the bleeding-edge branch for the result. > > Yeah, it looks fine. And I assume that you ar

Re: [PATCH V2 3/3] cpufreq: initialize governor for a new policy under policy->rwsem

2014-03-05 Thread Viresh Kumar
On 6 March 2014 09:04, Rafael J. Wysocki wrote: > I've rebased this one on top of 3.14-rc5 and queued it up for 3.14-rc6. > > Please check the bleeding-edge branch for the result. Yeah, it looks fine. And I assume that you are planning to take 1/3 in 3.15? Or going to drop it? -- To unsubscribe f

Re: [PATCH V2 3/3] cpufreq: initialize governor for a new policy under policy->rwsem

2014-03-05 Thread Rafael J. Wysocki
On Wednesday, March 05, 2014 05:10:01 PM Saravana Kannan wrote: > On 03/05/2014 05:06 PM, Rafael J. Wysocki wrote: > > On Thursday, March 06, 2014 02:04:39 AM Rafael J. Wysocki wrote: > >> On Tuesday, March 04, 2014 11:44:01 AM Viresh Kumar wrote: > >>> policy->rwsem is used to lock access to all p

Re: [PATCH V2 3/3] cpufreq: initialize governor for a new policy under policy->rwsem

2014-03-05 Thread Saravana Kannan
On 03/05/2014 05:06 PM, Rafael J. Wysocki wrote: On Thursday, March 06, 2014 02:04:39 AM Rafael J. Wysocki wrote: On Tuesday, March 04, 2014 11:44:01 AM Viresh Kumar wrote: policy->rwsem is used to lock access to all parts of code modifying struct cpufreq_policy but wasn't used on a new policy

Re: [PATCH V2 3/3] cpufreq: initialize governor for a new policy under policy->rwsem

2014-03-05 Thread Rafael J. Wysocki
On Thursday, March 06, 2014 02:04:39 AM Rafael J. Wysocki wrote: > On Tuesday, March 04, 2014 11:44:01 AM Viresh Kumar wrote: > > policy->rwsem is used to lock access to all parts of code modifying struct > > cpufreq_policy but wasn't used on a new policy created from > > __cpufreq_add_dev(). > >

Re: [PATCH V2 3/3] cpufreq: initialize governor for a new policy under policy->rwsem

2014-03-05 Thread Rafael J. Wysocki
On Tuesday, March 04, 2014 11:44:01 AM Viresh Kumar wrote: > policy->rwsem is used to lock access to all parts of code modifying struct > cpufreq_policy but wasn't used on a new policy created from > __cpufreq_add_dev(). > > Because of which if we call cpufreq_update_policy() repeatedly on one CP

[PATCH V2 3/3] cpufreq: initialize governor for a new policy under policy->rwsem

2014-03-03 Thread Viresh Kumar
policy->rwsem is used to lock access to all parts of code modifying struct cpufreq_policy but wasn't used on a new policy created from __cpufreq_add_dev(). Because of which if we call cpufreq_update_policy() repeatedly on one CPU and do offline/online of another CPU then we might see these crashes