Re: [PATCH V2 2/3] integrity: Move import of MokListRT certs to a separate routine

2020-09-11 Thread Lenny Szubowicz
On 9/11/20 3:08 PM, Mimi Zohar wrote: On Fri, 2020-09-11 at 21:16 +0300, Ard Biesheuvel wrote: I think we can just merge the patches as they are, with Mimi's R-b carried over. Other than the comments beginning on the "/*" line as opposed to the subsequent line, the updated 2/2 and 3/3 patches

Re: [PATCH V2 2/3] integrity: Move import of MokListRT certs to a separate routine

2020-09-11 Thread Mimi Zohar
On Fri, 2020-09-11 at 21:16 +0300, Ard Biesheuvel wrote: > I think we can just merge the patches as they are, with Mimi's R-b carried > over. Other than the comments beginning on the "/*" line as opposed to the subsequent line, the updated 2/2 and 3/3 patches look fine. thanks, Mimi

Re: [PATCH V2 2/3] integrity: Move import of MokListRT certs to a separate routine

2020-09-11 Thread Ard Biesheuvel
On Fri, 11 Sep 2020 at 20:18, Lenny Szubowicz wrote: > > On 9/11/20 11:59 AM, Mimi Zohar wrote: > > On Fri, 2020-09-11 at 11:54 -0400, Lenny Szubowicz wrote: > >> On 9/11/20 11:02 AM, Ard Biesheuvel wrote: > >>> On Sat, 5 Sep 2020 at 04:31, Lenny Szubowicz wrote: > > Move the loading of

Re: [PATCH V2 2/3] integrity: Move import of MokListRT certs to a separate routine

2020-09-11 Thread Lenny Szubowicz
On 9/11/20 11:59 AM, Mimi Zohar wrote: On Fri, 2020-09-11 at 11:54 -0400, Lenny Szubowicz wrote: On 9/11/20 11:02 AM, Ard Biesheuvel wrote: On Sat, 5 Sep 2020 at 04:31, Lenny Szubowicz wrote: Move the loading of certs from the UEFI MokListRT into a separate routine to facilitate additional M

Re: [PATCH V2 2/3] integrity: Move import of MokListRT certs to a separate routine

2020-09-11 Thread Ard Biesheuvel
On Sat, 5 Sep 2020 at 04:31, Lenny Szubowicz wrote: > > Move the loading of certs from the UEFI MokListRT into a separate > routine to facilitate additional MokList functionality. > > There is no visible functional change as a result of this patch. > Although the UEFI dbx certs are now loaded befo

Re: [PATCH V2 2/3] integrity: Move import of MokListRT certs to a separate routine

2020-09-11 Thread Mimi Zohar
On Fri, 2020-09-11 at 11:54 -0400, Lenny Szubowicz wrote: > On 9/11/20 11:02 AM, Ard Biesheuvel wrote: > > On Sat, 5 Sep 2020 at 04:31, Lenny Szubowicz wrote: > >> > >> Move the loading of certs from the UEFI MokListRT into a separate > >> routine to facilitate additional MokList functionality. >

Re: [PATCH V2 2/3] integrity: Move import of MokListRT certs to a separate routine

2020-09-11 Thread Lenny Szubowicz
On 9/11/20 11:02 AM, Ard Biesheuvel wrote: On Sat, 5 Sep 2020 at 04:31, Lenny Szubowicz wrote: Move the loading of certs from the UEFI MokListRT into a separate routine to facilitate additional MokList functionality. There is no visible functional change as a result of this patch. Although th

[PATCH V2 2/3] integrity: Move import of MokListRT certs to a separate routine

2020-09-04 Thread Lenny Szubowicz
Move the loading of certs from the UEFI MokListRT into a separate routine to facilitate additional MokList functionality. There is no visible functional change as a result of this patch. Although the UEFI dbx certs are now loaded before the MokList certs, they are loaded onto different key rings.