On Mon, 2012-10-15 at 08:59 +0530, Viresh Kumar wrote:
> On 12 October 2012 20:28, Andy Shevchenko
> wrote:
> >> + if (last_dw) {
> >> + if ((last_bus_id == param) && (last_dw == dw))
> >> + return false;
> >> + }
> > Just came to my mind.
> > dw can't be N
On 12 October 2012 20:28, Andy Shevchenko
wrote:
>> + if (last_dw) {
>> + if ((last_bus_id == param) && (last_dw == dw))
>> + return false;
>> + }
> Just came to my mind.
> dw can't be NULL, can't it?
> Then
> if (last_dw) {
> ...
> }
> is unneeded.
Fixup f
On 12 October 2012 21:50, Jean-Christophe PLAGNIOL-VILLARD
wrote:
>> >> - pass platform data via DT, non-DT way still takes precedence if both
>> >> are used.
>> > why keep it all platform are DT
>>
>> I would love to remove that, but not sure if somebody want's the non-DT
>> way too.
>>
>> I di
On 20:25 Fri 12 Oct , Viresh Kumar wrote:
> On 12 October 2012 20:20, Jean-Christophe PLAGNIOL-VILLARD
> wrote:
> > On 20:01 Fri 12 Oct , Viresh Kumar wrote:
> >> dw_dmac driver already supports device tree but it used to have its
> >> platform
> >> data passed the non-DT way.
> >>
> >> T
On 12 October 2012 21:23, Andy Shevchenko wrote:
> 1. This is an equivalent of
> if (last_dw && (last_bus_id == ... ) && (last_dw == dw))
> return false;
> 2. In case dw is always non-NULL the last_dw == dw is false if last_dw is
> NULL.
>
> Where am I wrong?
Nowhere, I am drunk ;)
--
viresh
-
On Fri, Oct 12, 2012 at 6:18 PM, Viresh Kumar wrote:
> On 12 October 2012 20:28, Andy Shevchenko
> wrote:
>> On Fri, 2012-10-12 at 20:01 +0530, Viresh Kumar wrote:
>
>>> + if (last_dw) {
>>> + if ((last_bus_id == param) && (last_dw == dw))
>>> + return false;
>
On 12 October 2012 20:28, Andy Shevchenko
wrote:
> On Fri, 2012-10-12 at 20:01 +0530, Viresh Kumar wrote:
>> + if (last_dw) {
>> + if ((last_bus_id == param) && (last_dw == dw))
>> + return false;
>> + }
> Just came to my mind.
> dw can't be NULL, can't it
On Fri, 2012-10-12 at 20:01 +0530, Viresh Kumar wrote:
> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
> @@ -1179,6 +1179,53 @@ static void dwc_free_chan_resources(struct dma_chan
> *chan)
> dev_vdbg(chan2dev(chan), "%s: done\n", __func__);
> }
>
> +bool dw_dma_generic_filt
On 12 October 2012 20:20, Jean-Christophe PLAGNIOL-VILLARD
wrote:
> On 20:01 Fri 12 Oct , Viresh Kumar wrote:
>> dw_dmac driver already supports device tree but it used to have its platform
>> data passed the non-DT way.
>>
>> This patch does following changes:
>> - pass platform data via DT,
On 20:01 Fri 12 Oct , Viresh Kumar wrote:
> dw_dmac driver already supports device tree but it used to have its platform
> data passed the non-DT way.
>
> This patch does following changes:
> - pass platform data via DT, non-DT way still takes precedence if both are
> used.
why keep it all p
dw_dmac driver already supports device tree but it used to have its platform
data passed the non-DT way.
This patch does following changes:
- pass platform data via DT, non-DT way still takes precedence if both are used.
- create generic filter routine
- Earlier slave information was made availabl
11 matches
Mail list logo
