Re: [PATCH V2 2/2] x86, mce, severities: Define mce_severity function pointer

2015-03-23 Thread Aravind Gopalakrishnan
On 3/21/2015 1:10 AM, Borislav Petkov wrote: On Fri, Mar 20, 2015 at 09:35:26PM -0500, Aravind Gopalakrishnan wrote: Other function pointers in the mce code like unexpected_machine_check and default_threshold_interrupt are assigned to the respective function pointers when they are defined. The

Re: [PATCH V2 2/2] x86, mce, severities: Define mce_severity function pointer

2015-03-20 Thread Borislav Petkov
On Fri, Mar 20, 2015 at 09:35:26PM -0500, Aravind Gopalakrishnan wrote: > Other function pointers in the mce code like unexpected_machine_check > and default_threshold_interrupt are assigned to the respective > function pointers when they are defined. The "WTF?!" would still fire and we don't want

Re: [PATCH V2 2/2] x86, mce, severities: Define mce_severity function pointer

2015-03-20 Thread Aravind Gopalakrishnan
On 3/20/15 5:31 PM, Luck, Tony wrote: + default: + WARN_ONCE(1, "WTF!?"); + break; You meant to type: mce_severity = mce_severity_default; just there, right? Other function pointers in the mce code like unexpected_machine_check and default_t

RE: [PATCH V2 2/2] x86, mce, severities: Define mce_severity function pointer

2015-03-20 Thread Luck, Tony
+ default: + WARN_ONCE(1, "WTF!?"); + break; You meant to type: mce_severity = mce_severity_default; just there, right? -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.k

[PATCH V2 2/2] x86, mce, severities: Define mce_severity function pointer

2015-03-20 Thread Aravind Gopalakrishnan
Rename mce_severity() as mce_severity_intel and assign mce_severity function pointer to either one of mce_severity_intel or mce_severity_amd during init depending on which processor we are on. This way, we can avoid a test to call mce_severity_amd every time we get into mce_severity(). And it's cl