Re: [PATCH V2 15/15] perf tools: fix ppid in thread__fork()

2013-06-28 Thread David Ahern
On 6/28/13 12:47 AM, Adrian Hunter wrote: knowledge of the specific thread within the parent that created the process can be valuable -- that's what we get now. This change drops that information. I'd prefer this stays at thread id -- or save the parent thread id in addition to the pid. That me

Re: [PATCH V2 15/15] perf tools: fix ppid in thread__fork()

2013-06-27 Thread Adrian Hunter
On 27/06/13 19:57, David Ahern wrote: > On 6/27/13 1:55 AM, Adrian Hunter wrote: >> ppid should be assigned to the parents pid. Note >> 'thread__fork()'s only caller 'machine__process_fork_event()' >> ensures that the parents pid is set. >> >> Signed-off-by: Adrian Hunter >> --- >> tools/perf/u

Re: [PATCH V2 15/15] perf tools: fix ppid in thread__fork()

2013-06-27 Thread David Ahern
On 6/27/13 1:55 AM, Adrian Hunter wrote: ppid should be assigned to the parents pid. Note 'thread__fork()'s only caller 'machine__process_fork_event()' ensures that the parents pid is set. Signed-off-by: Adrian Hunter --- tools/perf/util/thread.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH V2 15/15] perf tools: fix ppid in thread__fork()

2013-06-27 Thread Adrian Hunter
ppid should be assigned to the parents pid. Note 'thread__fork()'s only caller 'machine__process_fork_event()' ensures that the parents pid is set. Signed-off-by: Adrian Hunter --- tools/perf/util/thread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/threa