Re: [PATCH V2 1/5] mm/hugetlb: Enable PUD level huge page migration

2018-10-22 Thread Michal Hocko
On Mon 22-10-18 08:31:05, Anshuman Khandual wrote: > On 10/19/2018 01:39 PM, Michal Hocko wrote: > > I would probably fold it into the one which defines arch specific hook. > > Hmm but that may be like doing two functionality changes together. Adding one > more conditional check and at the same ti

Re: [PATCH V2 1/5] mm/hugetlb: Enable PUD level huge page migration

2018-10-21 Thread Anshuman Khandual
On 10/19/2018 01:39 PM, Michal Hocko wrote: > I planed to get to review this earlier but been busy. Anyway, this patch > should be applied only after movability one to prevent from > (theoretical) bisectability issues. Sure, I can change the order there. > > I would probably fold it into the

Re: [PATCH V2 1/5] mm/hugetlb: Enable PUD level huge page migration

2018-10-19 Thread Michal Hocko
I planed to get to review this earlier but been busy. Anyway, this patch should be applied only after movability one to prevent from (theoretical) bisectability issues. I would probably fold it into the one which defines arch specific hook. On Fri 12-10-18 09:29:55, Anshuman Khandual wrote: > Arc

[PATCH V2 1/5] mm/hugetlb: Enable PUD level huge page migration

2018-10-11 Thread Anshuman Khandual
Architectures like arm64 have PUD level HugeTLB pages for certain configs (1GB huge page is PUD based on ARM64_4K_PAGES base page size) that can be enabled for migration. It can be achieved through checking for PUD_SHIFT order based HugeTLB pages during migration. Signed-off-by: Anshuman Khandual