Re: [PATCH V2 1/3] virtio: allow nested disabling of the configure interrupt

2024-06-25 Thread Michael S. Tsirkin
On Tue, Jun 25, 2024 at 04:18:00PM +0800, Jason Wang wrote: > > > > > > > > > > > > > > > > But in conclusion ;) if you don't like my suggestion do something else > > > > but make the APIs make sense, > > > > > > I don't say I don't like it:) > > > > > > Limiting it to virtio-net seems to be the mo

Re: [PATCH V2 1/3] virtio: allow nested disabling of the configure interrupt

2024-06-25 Thread Jason Wang
On Tue, Jun 25, 2024 at 4:04 PM Michael S. Tsirkin wrote: > > On Tue, Jun 25, 2024 at 03:50:30PM +0800, Jason Wang wrote: > > On Tue, Jun 25, 2024 at 3:11 PM Michael S. Tsirkin wrote: > > > > > > On Tue, Jun 25, 2024 at 09:27:04AM +0800, Jason Wang wrote: > > > > On Mon, Jun 24, 2024 at 5:59 PM M

Re: [PATCH V2 1/3] virtio: allow nested disabling of the configure interrupt

2024-06-25 Thread Michael S. Tsirkin
On Tue, Jun 25, 2024 at 03:50:30PM +0800, Jason Wang wrote: > On Tue, Jun 25, 2024 at 3:11 PM Michael S. Tsirkin wrote: > > > > On Tue, Jun 25, 2024 at 09:27:04AM +0800, Jason Wang wrote: > > > On Mon, Jun 24, 2024 at 5:59 PM Michael S. Tsirkin > > > wrote: > > > > > > > > On Mon, Jun 24, 2024 a

Re: [PATCH V2 1/3] virtio: allow nested disabling of the configure interrupt

2024-06-25 Thread Jason Wang
On Tue, Jun 25, 2024 at 3:11 PM Michael S. Tsirkin wrote: > > On Tue, Jun 25, 2024 at 09:27:04AM +0800, Jason Wang wrote: > > On Mon, Jun 24, 2024 at 5:59 PM Michael S. Tsirkin wrote: > > > > > > On Mon, Jun 24, 2024 at 10:45:21AM +0800, Jason Wang wrote: > > > > Somtime driver may want to enable

Re: [PATCH V2 1/3] virtio: allow nested disabling of the configure interrupt

2024-06-25 Thread Michael S. Tsirkin
On Tue, Jun 25, 2024 at 09:27:04AM +0800, Jason Wang wrote: > On Mon, Jun 24, 2024 at 5:59 PM Michael S. Tsirkin wrote: > > > > On Mon, Jun 24, 2024 at 10:45:21AM +0800, Jason Wang wrote: > > > Somtime driver may want to enable or disable the config callback. This > > > requires a synchronization

Re: [PATCH V2 1/3] virtio: allow nested disabling of the configure interrupt

2024-06-24 Thread Jason Wang
On Mon, Jun 24, 2024 at 5:59 PM Michael S. Tsirkin wrote: > > On Mon, Jun 24, 2024 at 10:45:21AM +0800, Jason Wang wrote: > > Somtime driver may want to enable or disable the config callback. This > > requires a synchronization with the core. So this patch change the > > config_enabled to be a int

Re: [PATCH V2 1/3] virtio: allow nested disabling of the configure interrupt

2024-06-24 Thread Michael S. Tsirkin
On Mon, Jun 24, 2024 at 10:45:21AM +0800, Jason Wang wrote: > Somtime driver may want to enable or disable the config callback. This > requires a synchronization with the core. So this patch change the > config_enabled to be a integer counter. This allows the toggling of > the config_enable to be s

[PATCH V2 1/3] virtio: allow nested disabling of the configure interrupt

2024-06-23 Thread Jason Wang
Somtime driver may want to enable or disable the config callback. This requires a synchronization with the core. So this patch change the config_enabled to be a integer counter. This allows the toggling of the config_enable to be synchronized between the virtio core and the virtio driver. The coun