Re: [PATCH V2 1/2] mfd: stmpe: Use devm_*() routines

2012-11-23 Thread Samuel Ortiz
Hi Viresh, On Thu, Nov 22, 2012 at 10:40:29AM +0530, Viresh Kumar wrote: > This patch frees stmpe driver from tension of freeing resources :) > devm_* derivatives of multiple routines are used while allocating resources, > which would be freed automatically by kernel. > > Signed-off-by: Viresh Ku

Re: [PATCH V2 1/2] mfd: stmpe: Use devm_*() routines

2012-11-23 Thread Viresh Kumar
On 23 November 2012 15:10, Lee Jones wrote: > That's not how it works. > > Apply my Acked-by yourself and re-send the patch-set as a whole. I don't thinks so. This patch is not doing anything with DT stuff and so can be applied separately. Related patches should be posted together though. -- vir

Re: [PATCH V2 1/2] mfd: stmpe: Use devm_*() routines

2012-11-23 Thread Lee Jones
On Fri, 23 Nov 2012, Lee Jones wrote: > On Thu, 22 Nov 2012, Viresh Kumar wrote: > > > On 22 November 2012 15:57, Lee Jones wrote: > > > On Thu, 22 Nov 2012, Viresh Kumar wrote: > > > > > >> This patch frees stmpe driver from tension of freeing resources :) > > >> devm_* derivatives of multiple

Re: [PATCH V2 1/2] mfd: stmpe: Use devm_*() routines

2012-11-23 Thread Lee Jones
On Thu, 22 Nov 2012, Viresh Kumar wrote: > On 22 November 2012 15:57, Lee Jones wrote: > > On Thu, 22 Nov 2012, Viresh Kumar wrote: > > > >> This patch frees stmpe driver from tension of freeing resources :) > >> devm_* derivatives of multiple routines are used while allocating > >> resources, >

Re: [PATCH V2 1/2] mfd: stmpe: Use devm_*() routines

2012-11-22 Thread Viresh Kumar
On 22 November 2012 15:57, Lee Jones wrote: > On Thu, 22 Nov 2012, Viresh Kumar wrote: > >> This patch frees stmpe driver from tension of freeing resources :) >> devm_* derivatives of multiple routines are used while allocating resources, >> which would be freed automatically by kernel. >> >> Sign

Re: [PATCH V2 1/2] mfd: stmpe: Use devm_*() routines

2012-11-22 Thread Viresh Kumar
On 22 November 2012 15:57, Lee Jones wrote: > I'm assuming you've reversed the semantics here for >80 chars reasons? Not for 80 chars reason :) I did it to decrease nesting level of if/else statements :) -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH V2 1/2] mfd: stmpe: Use devm_*() routines

2012-11-22 Thread Lee Jones
On Thu, 22 Nov 2012, Viresh Kumar wrote: > This patch frees stmpe driver from tension of freeing resources :) > devm_* derivatives of multiple routines are used while allocating resources, > which would be freed automatically by kernel. > > Signed-off-by: Viresh Kumar > --- > > V1->V2: > --

[PATCH V2 1/2] mfd: stmpe: Use devm_*() routines

2012-11-22 Thread Viresh Kumar
This patch frees stmpe driver from tension of freeing resources :) devm_* derivatives of multiple routines are used while allocating resources, which would be freed automatically by kernel. Signed-off-by: Viresh Kumar --- V1->V2: -- - Rebased over latest for-next from Samuel - updated additi