Re: [PATCH V2 05/12] perf mem: Factor out a function to generate sort order

2020-12-04 Thread Jiri Olsa
On Mon, Nov 30, 2020 at 09:27:56AM -0800, kan.li...@linux.intel.com wrote: > From: Kan Liang > > Now, "--phys-data" is the only option which impacts the sort order. > A simple "if else" is enough to handle the option. But there will be > more options added, e.g. "--data-page-size", which also imp

[PATCH V2 05/12] perf mem: Factor out a function to generate sort order

2020-11-30 Thread kan . liang
From: Kan Liang Now, "--phys-data" is the only option which impacts the sort order. A simple "if else" is enough to handle the option. But there will be more options added, e.g. "--data-page-size", which also impact the sort order. The code will become too complex to be maintained. Divide the so