RE: [PATCH V2 02/12] misc: xilinx-sdfec: add core driver

el@vger.kernel.org; Derek > Kiernan > Subject: Re: [PATCH V2 02/12] misc: xilinx-sdfec: add core driver > > On Tue, Apr 09, 2019 at 11:06:44AM +0100, Dragan Cvetic wrote: > > +++ b/include/uapi/misc/xilinx_sdfec.h > > @@ -0,0 +1,42 @@ > > +/* SPDX-License-Identifi

Re: [PATCH V2 02/12] misc: xilinx-sdfec: add core driver

On Tue, Apr 09, 2019 at 11:06:44AM +0100, Dragan Cvetic wrote: > +++ b/include/uapi/misc/xilinx_sdfec.h > @@ -0,0 +1,42 @@ > +/* SPDX-License-Identifier: GPL-2.0+ */ That is not the proper SPDX license for a UAPI kernel header file :( Please fix this up. Also, why do you need a uapi file at all?

[PATCH V2 02/12] misc: xilinx-sdfec: add core driver

Implements an platform driver that matches with xlnx, sd-fec-1.1 device tree node and registers as a character device, including: - SD-FEC driver binds to sdfec DT node. - creates and initialise an initial driver dev structure. - add the driver in Linux build and Kconfig. Tested-by: Dragan Cvetic