Re: [PATCH V2] mips: txx9: fix resource leak after register fail

On 9/5/2018 11:37 PM, Atsushi Nemoto wrote: On Wed, 5 Sep 2018 19:22:19 +0800, Ding Xiang wrote: the memory allocated and ioremap address need free after device_register return error. ... exit_put: put_device(&dev->dev); - return; +exit_free: + iounmap(dev->base); +

Re: [PATCH V2] mips: txx9: fix resource leak after register fail

On Wed, 5 Sep 2018 19:22:19 +0800, Ding Xiang wrote: > the memory allocated and ioremap address need free after > device_register return error. ... > exit_put: > put_device(&dev->dev); > - return; > +exit_free: > + iounmap(dev->base); > + kfree(dev); This change will break ex

[PATCH V2] mips: txx9: fix resource leak after register fail

the memory allocated and ioremap address need free after device_register return error. v2: remove redundant "return" Signed-off-by: Ding Xiang --- arch/mips/txx9/generic/setup.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/mips/txx9/generic/setup.c b/arch/mips