Re: [PATCH V2] cpuidle/governors: Fix logic in selection of idle states

2014-01-28 Thread Preeti U Murthy
Hi Daniel, On 01/28/2014 02:16 PM, Daniel Lezcano wrote: > On 01/24/2014 11:21 AM, Preeti U Murthy wrote: >> On 01/24/2014 02:38 PM, Daniel Lezcano wrote: >>> On 01/23/2014 12:15 PM, Preeti U Murthy wrote: Hi Daniel, Thank you for the review. > > [ ... ] > --- drivers

Re: [PATCH V2] cpuidle/governors: Fix logic in selection of idle states

2014-01-28 Thread Daniel Lezcano
On 01/24/2014 11:21 AM, Preeti U Murthy wrote: On 01/24/2014 02:38 PM, Daniel Lezcano wrote: On 01/23/2014 12:15 PM, Preeti U Murthy wrote: Hi Daniel, Thank you for the review. [ ... ] --- drivers/cpuidle/cpuidle.c | 15 + drivers/cpuidle/governors/ladder.c | 101 +

Re: [PATCH V2] cpuidle/governors: Fix logic in selection of idle states

2014-01-24 Thread Preeti U Murthy
On 01/24/2014 02:38 PM, Daniel Lezcano wrote: > On 01/23/2014 12:15 PM, Preeti U Murthy wrote: >> Hi Daniel, >> >> Thank you for the review. >> >> On 01/22/2014 01:59 PM, Daniel Lezcano wrote: >>> On 01/17/2014 05:33 AM, Preeti U Murthy wrote: diff --git a/drivers/cpuidle/cpuidle.c b/driv

Re: [PATCH V2] cpuidle/governors: Fix logic in selection of idle states

2014-01-24 Thread Daniel Lezcano
On 01/23/2014 12:15 PM, Preeti U Murthy wrote: Hi Daniel, Thank you for the review. On 01/22/2014 01:59 PM, Daniel Lezcano wrote: On 01/17/2014 05:33 AM, Preeti U Murthy wrote: diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c index a55e68f..831b664 100644 --- a/drivers/cpui

Re: [PATCH V2] cpuidle/governors: Fix logic in selection of idle states

2014-01-23 Thread Preeti U Murthy
Hi Daniel, Thank you for the review. On 01/22/2014 01:59 PM, Daniel Lezcano wrote: > On 01/17/2014 05:33 AM, Preeti U Murthy wrote: >> >> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c >> index a55e68f..831b664 100644 >> --- a/drivers/cpuidle/cpuidle.c >> +++ b/drivers/cpuidle

Re: [PATCH V2] cpuidle/governors: Fix logic in selection of idle states

2014-01-22 Thread Daniel Lezcano
On 01/17/2014 05:33 AM, Preeti U Murthy wrote: The cpuidle governors today are not handling scenarios where no idle state can be chosen. Such scenarios coud arise if the user has disabled all the idle states at runtime or the latency requirement from the cpus is very strict. The menu governor re

[PATCH V2] cpuidle/governors: Fix logic in selection of idle states

2014-01-16 Thread Preeti U Murthy
The cpuidle governors today are not handling scenarios where no idle state can be chosen. Such scenarios coud arise if the user has disabled all the idle states at runtime or the latency requirement from the cpus is very strict. The menu governor returns 0th index of the idle state table when no o