Re: [PATCH V2] ZBOOT: fix stack protector in compressed boot phase

2018-03-14 Thread Yoshinori Sato
On Tue, 13 Mar 2018 17:55:53 +0900, Huacai Chen wrote: > > Hi, Yoshinori, Rich and SuperH developers, > > I'm not familiar with SuperH assembly, but SuperH has the same bug > obviously. Could you please fix that? > > Huacai > Sorry. Previous mail bounced. It resend. OK. Apply this fix. SuperH

Re: [PATCH V2] ZBOOT: fix stack protector in compressed boot phase

2018-03-14 Thread Yoshinori Sato
On Tue, 13 Mar 2018 17:55:53 +0900, Huacai Chen wrote: > > Hi, Yoshinori, Rich and SuperH developers, > > I'm not familiar with SuperH assembly, but SuperH has the same bug > obviously. Could you please fix that? > > Huacai > OK. Apply this fix. SuperH can not handle long int directly. diff --

Re: [PATCH V2] ZBOOT: fix stack protector in compressed boot phase

2018-03-13 Thread Huacai Chen
Hi, Yoshinori, Rich and SuperH developers, I'm not familiar with SuperH assembly, but SuperH has the same bug obviously. Could you please fix that? Huacai On Mon, Mar 12, 2018 at 10:04 AM, Huacai Chen wrote: > Call __stack_chk_guard_setup() in decompress_kernel() is too late that > stack checki

Re: [PATCH V2] ZBOOT: fix stack protector in compressed boot phase

2018-03-11 Thread kbuild test robot
Hi Huacai, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc5 next-20180309] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

[PATCH V2] ZBOOT: fix stack protector in compressed boot phase

2018-03-11 Thread Huacai Chen
Call __stack_chk_guard_setup() in decompress_kernel() is too late that stack checking always fails for decompress_kernel() itself. So remove __stack_chk_guard_setup() and initialize __stack_chk_guard before we call decompress_kernel(). Original code comes from ARM but also used for MIPS and SH, so