Re: [PATCH V2] GPIO: gpio-pxa: fix bug when get gpio value

2012-09-30 Thread Linus Walleij
On Wed, Sep 26, 2012 at 3:46 AM, Neil Zhang wrote: > We need to return 0 or 1 when get gpio value. > > Signed-off-by: Neil Zhang Aha there is another patch fixing that comment I had, sorry, going through the mail backlog. But you need to take Haojian's comments into account so I'm not applying

RE: [PATCH V2] GPIO: gpio-pxa: fix bug when get gpio value

2012-09-26 Thread Neil Zhang
> -Original Message- > From: Haojian Zhuang [mailto:haojian.zhu...@gmail.com] > Sent: 2012年9月26日 14:44 > To: Neil Zhang > Cc: grant.lik...@secretlab.ca; linus.wall...@linaro.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH V2] GPIO: gpio-pxa: fix bug when g

Re: [PATCH V2] GPIO: gpio-pxa: fix bug when get gpio value

2012-09-25 Thread Haojian Zhuang
On Wed, Sep 26, 2012 at 9:46 AM, Neil Zhang wrote: > We need to return 0 or 1 when get gpio value. > > Signed-off-by: Neil Zhang > --- > drivers/gpio/gpio-pxa.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c > in

[PATCH V2] GPIO: gpio-pxa: fix bug when get gpio value

2012-09-25 Thread Neil Zhang
We need to return 0 or 1 when get gpio value. Signed-off-by: Neil Zhang --- drivers/gpio/gpio-pxa.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c index 9cac88a..3c9dc8c 100644 --- a/drivers/gpio/gpio-pxa.c +++ b/driv