On 4/28/2016 3:30 PM, Sinan Kaya wrote:
> On 4/26/2016 12:24 PM, Vinod Koul wrote:
>>> +
+ dev_err(lldev->dev, "error 0x%x, resetting...\n",
+ cause);
>> right justify this and others as well please
>>
>
> Can you please point me to other lines that need to be fixed p
On 4/26/2016 12:24 PM, Vinod Koul wrote:
>> +
>> > + dev_err(lldev->dev, "error 0x%x, resetting...\n",
>> > + cause);
> right justify this and others as well please
>
Can you please point me to other lines that need to be fixed please? It looks
good
to me though it doesn't to
On Tue, Apr 26, 2016 at 11:04:55AM -0400, Sinan Kaya wrote:
> On 4/25/2016 11:28 PM, Vinod Koul wrote:
> >> +
> >> + /* reset the channel for recovery */
> >> + if (hidma_ll_setup(lldev)) {
> >
> > should this be done in ISR?
>
> I created a new tasklet called rs
On 4/26/2016 11:10 AM, Andy Shevchenko wrote:
> On Tue, Apr 26, 2016 at 6:04 PM, Sinan Kaya wrote:
>> On 4/25/2016 11:28 PM, Vinod Koul wrote:
>>> On Mon, Apr 11, 2016 at 10:21:11AM -0400, Sinan Kaya wrote:
>
+while (cause) {
+if ((cause & BIT(HIDMA_IRQ_TR_CH_INVALID_TRE
On Tue, Apr 26, 2016 at 6:04 PM, Sinan Kaya wrote:
> On 4/25/2016 11:28 PM, Vinod Koul wrote:
>> On Mon, Apr 11, 2016 at 10:21:11AM -0400, Sinan Kaya wrote:
>>> +while (cause) {
>>> +if ((cause & BIT(HIDMA_IRQ_TR_CH_INVALID_TRE_BIT_POS)) ||
>>> +(cause & BIT(HIDMA_
On 4/25/2016 11:28 PM, Vinod Koul wrote:
> On Mon, Apr 11, 2016 at 10:21:11AM -0400, Sinan Kaya wrote:
>
>> + * HIDMA is not aware of IOMMU presence since it follows the DMA API. All
>> + * IOMMU latency will be built into the data movement time. By the time
>> + * interrupt happens, IOMMU lookups
On Mon, Apr 11, 2016 at 10:21:11AM -0400, Sinan Kaya wrote:
> + * HIDMA is not aware of IOMMU presence since it follows the DMA API. All
> + * IOMMU latency will be built into the data movement time. By the time
> + * interrupt happens, IOMMU lookups + data movement has already taken place.
Do yo
This patch implements the hardware hooks for the HIDMA channel driver.
The main functions of interest are:
- hidma_ll_init
- hidma_ll_request
- hidma_ll_queue_request
- hidma_ll_hw_start
OS layer calls the hidma_ll_init function during probe to set up the
hardware. At this moment, the number of s
8 matches
Mail list logo
