Re: [PATCH V14 0/3] blk-mq: refactor and fix the code of issue directly

2018-12-14 Thread Jens Axboe
On 12/13/18 6:28 PM, Jianchao Wang wrote: > Hi Jens > > After commit c616cbee ( blk-mq: punt failed direct issue to dispatch > list ), we always insert request to hctx dispatch list whenever get a > BLK_STS_RESOURCE or BLK_STS_DEV_RESOURCE, this is overkill and will > harm the merging. We just nee

Re: [PATCH V14 0/3] blk-mq: refactor and fix the code of issue directly

2018-12-13 Thread Jens Axboe
On 12/13/18 6:28 PM, Jianchao Wang wrote: > Hi Jens > > After commit c616cbee ( blk-mq: punt failed direct issue to dispatch > list ), we always insert request to hctx dispatch list whenever get a > BLK_STS_RESOURCE or BLK_STS_DEV_RESOURCE, this is overkill and will > harm the merging. We just nee

[PATCH V14 0/3] blk-mq: refactor and fix the code of issue directly

2018-12-13 Thread Jianchao Wang
Hi Jens After commit c616cbee ( blk-mq: punt failed direct issue to dispatch list ), we always insert request to hctx dispatch list whenever get a BLK_STS_RESOURCE or BLK_STS_DEV_RESOURCE, this is overkill and will harm the merging. We just need to do that for the requests that has been through .q