Re: [PATCH V1 RESEND 1/3] perf/imx_ddr: Add system PMU identifier for userspace

2020-05-27 Thread Shaokun Zhang
Hi, On 2020/5/27 22:34, John Garry wrote: > > I also really dislike this. What's the preferred way to identify the SoC > from userspace? /proc/cpuinfo? ;) >>> >>> The *SoC*! >>> For an non-firmware specific case, I'd say soc_device should be. I'd guess ACPI systems

Re: [PATCH V1 RESEND 1/3] perf/imx_ddr: Add system PMU identifier for userspace

2020-05-27 Thread John Garry
I also really dislike this. What's the preferred way to identify the SoC from userspace? /proc/cpuinfo? ;) The *SoC*! For an non-firmware specific case, I'd say soc_device should be. I'd guess ACPI systems don't use it and for them it's dmidecode typically. The other problem I have with s

Re: [PATCH V1 RESEND 1/3] perf/imx_ddr: Add system PMU identifier for userspace

2020-05-21 Thread John Garry
On 21/05/2020 14:26, Mark Rutland wrote: On Wed, May 20, 2020 at 08:33:04AM +0100, Will Deacon wrote: On Tue, May 19, 2020 at 12:51:25PM -0600, Rob Herring wrote: On Tue, May 12, 2020 at 03:31:13PM +0800, Joakim Zhang wrote: +static ssize_t ddr_perf_identifier_show(struct device *dev, +

Re: [PATCH V1 RESEND 1/3] perf/imx_ddr: Add system PMU identifier for userspace

2020-05-21 Thread John Garry
On 21/05/2020 14:04, Will Deacon wrote: On Wed, May 20, 2020 at 09:23:41AM -0600, Rob Herring wrote: On Wed, May 20, 2020 at 1:33 AM Will Deacon wrote: On Tue, May 19, 2020 at 12:51:25PM -0600, Rob Herring wrote: On Tue, May 12, 2020 at 03:31:13PM +0800, Joakim Zhang wrote: +static ssize_t

Re: [PATCH V1 RESEND 1/3] perf/imx_ddr: Add system PMU identifier for userspace

2020-05-21 Thread Mark Rutland
On Wed, May 20, 2020 at 08:33:04AM +0100, Will Deacon wrote: > On Tue, May 19, 2020 at 12:51:25PM -0600, Rob Herring wrote: > > On Tue, May 12, 2020 at 03:31:13PM +0800, Joakim Zhang wrote: > > > +static ssize_t ddr_perf_identifier_show(struct device *dev, > > > + st

Re: [PATCH V1 RESEND 1/3] perf/imx_ddr: Add system PMU identifier for userspace

2020-05-21 Thread Will Deacon
On Wed, May 20, 2020 at 09:23:41AM -0600, Rob Herring wrote: > On Wed, May 20, 2020 at 1:33 AM Will Deacon wrote: > > > > On Tue, May 19, 2020 at 12:51:25PM -0600, Rob Herring wrote: > > > On Tue, May 12, 2020 at 03:31:13PM +0800, Joakim Zhang wrote: > > > > +static ssize_t ddr_perf_identifier_sho

Re: [PATCH V1 RESEND 1/3] perf/imx_ddr: Add system PMU identifier for userspace

2020-05-20 Thread Rob Herring
On Wed, May 20, 2020 at 1:33 AM Will Deacon wrote: > > On Tue, May 19, 2020 at 12:51:25PM -0600, Rob Herring wrote: > > On Tue, May 12, 2020 at 03:31:13PM +0800, Joakim Zhang wrote: > > > +static ssize_t ddr_perf_identifier_show(struct device *dev, > > > + struct

Re: [PATCH V1 RESEND 1/3] perf/imx_ddr: Add system PMU identifier for userspace

2020-05-20 Thread Rob Herring
rnel.org; dl-linux-imx ; > > linux-arm-ker...@lists.infradead.org; devicet...@vger.kernel.org; > > linux-kernel@vger.kernel.org > > Subject: Re: [PATCH V1 RESEND 1/3] perf/imx_ddr: Add system PMU identifier > > for userspace > > > > On Tue, May 12, 2020 at 03:31:13PM +0800,

Re: [PATCH V1 RESEND 1/3] perf/imx_ddr: Add system PMU identifier for userspace

2020-05-20 Thread Will Deacon
On Tue, May 19, 2020 at 12:51:25PM -0600, Rob Herring wrote: > On Tue, May 12, 2020 at 03:31:13PM +0800, Joakim Zhang wrote: > > +static ssize_t ddr_perf_identifier_show(struct device *dev, > > + struct device_attribute *attr, > > +

RE: [PATCH V1 RESEND 1/3] perf/imx_ddr: Add system PMU identifier for userspace

2020-05-19 Thread Joakim Zhang
l.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH V1 RESEND 1/3] perf/imx_ddr: Add system PMU identifier > for userspace > > On Tue, May 12, 2020 at 03:31:13PM +0800, Joakim Zhang wrote: > > The DDR Perf for i.MX8 is a system PMU whose axi id would different > > from S

Re: [PATCH V1 RESEND 1/3] perf/imx_ddr: Add system PMU identifier for userspace

2020-05-19 Thread Rob Herring
On Tue, May 12, 2020 at 03:31:13PM +0800, Joakim Zhang wrote: > The DDR Perf for i.MX8 is a system PMU whose axi id would different from > SoC to SoC. Need expose system PMU identifier for userspace which refer > to /sys/bus/event_source/devices//identifier. Why not just expose the AXI ID if that'

[PATCH V1 RESEND 1/3] perf/imx_ddr: Add system PMU identifier for userspace

2020-05-12 Thread Joakim Zhang
The DDR Perf for i.MX8 is a system PMU whose axi id would different from SoC to SoC. Need expose system PMU identifier for userspace which refer to /sys/bus/event_source/devices//identifier. Reviewed-by: John Garry Signed-off-by: Joakim Zhang --- drivers/perf/fsl_imx8_ddr_perf.c | 45 ++