Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions

2016-12-30 Thread Linus Walleij
On Thu, Dec 29, 2016 at 8:20 AM, Robert Jarzmik wrote: > Linus Walleij writes: > >> On Thu, Dec 8, 2016 at 3:35 PM, Arvind Yadav >> wrote: >> >>> In functions pxa2xx_build_functions, the memory allocated for >>> 'functions' is live within the function only. After the >>> allocation it is immedi

Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions

2016-12-28 Thread Robert Jarzmik
Linus Walleij writes: > On Thu, Dec 8, 2016 at 3:35 PM, Arvind Yadav > wrote: > >> In functions pxa2xx_build_functions, the memory allocated for >> 'functions' is live within the function only. After the >> allocation it is immediately freed with devm_kfree. There is >> no need to allocate memo

Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions

2016-12-27 Thread Linus Walleij
On Thu, Dec 8, 2016 at 3:35 PM, Arvind Yadav wrote: > In functions pxa2xx_build_functions, the memory allocated for > 'functions' is live within the function only. After the > allocation it is immediately freed with devm_kfree. There is > no need to allocate memory for 'functions' with devm funct

Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions

2016-12-11 Thread arvind Yadav
Yes, It will not fixes any defect. But we are going to free allocate memory then why we need devm api. In this case Devm will first add this entry to list and immediately it will remove from list. -Arvind On Saturday 10 December 2016 02:49 PM, Robert Jarzmik wrote: Arvind Yadav writes: Hi Ar

Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions

2016-12-10 Thread Robert Jarzmik
Arvind Yadav writes: Hi Arvind, > In functions pxa2xx_build_functions, the memory allocated for > 'functions' is live within the function only. After the > allocation it is immediately freed with devm_kfree. There is > no need to allocate memory for 'functions' with devm function > so replace de

Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions

2016-12-08 Thread Robin Murphy
On 08/12/16 15:20, Robin Murphy wrote: > On 08/12/16 14:35, Arvind Yadav wrote: >> In functions pxa2xx_build_functions, the memory allocated for >> 'functions' is live within the function only. After the >> allocation it is immediately freed with devm_kfree. There is >> no need to allocate memory f

Re: [PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions

2016-12-08 Thread Robin Murphy
On 08/12/16 14:35, Arvind Yadav wrote: > In functions pxa2xx_build_functions, the memory allocated for > 'functions' is live within the function only. After the > allocation it is immediately freed with devm_kfree. There is > no need to allocate memory for 'functions' with devm function > so replac

[PATCH V1] pinctrl:pxa:pinctrl-pxa2xx:- No need of devm functions

2016-12-08 Thread Arvind Yadav
In functions pxa2xx_build_functions, the memory allocated for 'functions' is live within the function only. After the allocation it is immediately freed with devm_kfree. There is no need to allocate memory for 'functions' with devm function so replace devm_kcalloc with kcalloc and devm_kfree with