Re: [PATCH TRIVIAL] bsg: use pr_debug instead of hand crafted macros

2018-01-22 Thread Joe Perches
On Mon, 2018-01-22 at 20:42 +, Bart Van Assche wrote: > On Mon, 2018-01-22 at 12:23 -0800, Joe Perches wrote: > > On Mon, 2018-01-22 at 08:53 +0100, Johannes Thumshirn wrote: > > > Use pr_debug instead of hand crafted macros. This way it is not needed to > > > re-compile the kernel to enable bs

Re: [PATCH TRIVIAL] bsg: use pr_debug instead of hand crafted macros

2018-01-22 Thread Bart Van Assche
On Mon, 2018-01-22 at 12:23 -0800, Joe Perches wrote: > On Mon, 2018-01-22 at 08:53 +0100, Johannes Thumshirn wrote: > > Use pr_debug instead of hand crafted macros. This way it is not needed to > > re-compile the kernel to enable bsg debug outputs and it's possible to > > selectively enable specif

Re: [PATCH TRIVIAL] bsg: use pr_debug instead of hand crafted macros

2018-01-22 Thread Joe Perches
On Mon, 2018-01-22 at 08:53 +0100, Johannes Thumshirn wrote: > Use pr_debug instead of hand crafted macros. This way it is not needed to > re-compile the kernel to enable bsg debug outputs and it's possible to > selectively enable specific prints. Perhaps better to use #define bsg_dbg(bd, fmt, ..

Re: [PATCH TRIVIAL] bsg: use pr_debug instead of hand crafted macros

2018-01-22 Thread Bart Van Assche
On 01/21/18 23:53, Johannes Thumshirn wrote: - dprintk("map hdr %llx/%u %llx/%u\n", (unsigned long long) hdr->dout_xferp, + pr_debug("map hdr %llx/%u %llx/%u\n", +(unsigned long long) hdr->dout_xferp, hdr->dout_xfer_len, (unsigned long long) hdr->din_x

[PATCH TRIVIAL] bsg: use pr_debug instead of hand crafted macros

2018-01-21 Thread Johannes Thumshirn
Use pr_debug instead of hand crafted macros. This way it is not needed to re-compile the kernel to enable bsg debug outputs and it's possible to selectively enable specific prints. Signed-off-by: Johannes Thumshirn --- block/bsg.c | 35 +-- 1 file changed, 13 inse