Re: [PATCH RT 3/3 - take two ] fix get_monotonic_cycles for latency tracer

2007-08-25 Thread Steven Rostedt
-- On Sat, 25 Aug 2007, Frank Ch. Eigler wrote: > > Steven Rostedt <[EMAIL PROTECTED]> writes: > > > [...] > > +* [...] We don't need to grab > > +* any locks, we just keep trying until get all the > > +* calculations together in one state. > > +* >

Re: [PATCH RT 3/3 - take two ] fix get_monotonic_cycles for latency tracer

2007-08-25 Thread Frank Ch. Eigler
Steven Rostedt <[EMAIL PROTECTED]> writes: > [...] > + * [...] We don't need to grab > + * any locks, we just keep trying until get all the > + * calculations together in one state. > + * > + * In fact, we __cant__ grab any locks. T

[PATCH RT 3/3 - take two ] fix get_monotonic_cycles for latency tracer

2007-08-24 Thread Steven Rostedt
[Added comment about not being able to take the xtime lock in get_monotonic_cycles - suggested by John Stultz] The latency tracer on SMP was given crazy results. It was found that the get_monotonic_cycles that it uses was not returning a monotonic counter. The cause of this was that clock->cycl