Re: [PATCH RT] convert RCU Preempt tasklet into softirq.

2007-09-06 Thread Paul E. McKenney
On Thu, Sep 06, 2007 at 12:52:00PM -0500, Clark Williams wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Paul E. McKenney wrote: > > On Fri, Jun 08, 2007 at 03:43:48PM -0400, Steven Rostedt wrote: > >> On Fri, 2007-06-08 at 12:36 -0700, Paul E. McKenney wrote: > >>> On Fri, Jun 08, 20

Re: [PATCH RT] convert RCU Preempt tasklet into softirq.

2007-09-06 Thread Clark Williams
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Paul E. McKenney wrote: > On Fri, Jun 08, 2007 at 03:43:48PM -0400, Steven Rostedt wrote: >> On Fri, 2007-06-08 at 12:36 -0700, Paul E. McKenney wrote: >>> On Fri, Jun 08, 2007 at 11:27:08AM -0400, Steven Rostedt wrote: The first time I compiled i

Re: [PATCH RT] convert RCU Preempt tasklet into softirq.

2007-06-08 Thread Paul E. McKenney
On Fri, Jun 08, 2007 at 03:43:48PM -0400, Steven Rostedt wrote: > On Fri, 2007-06-08 at 12:36 -0700, Paul E. McKenney wrote: > > On Fri, Jun 08, 2007 at 11:27:08AM -0400, Steven Rostedt wrote: > > > > The first time I compiled it, I forgot the ';' and got a warning there. > > > But the warning als

Re: [PATCH RT] convert RCU Preempt tasklet into softirq.

2007-06-08 Thread Steven Rostedt
On Fri, 2007-06-08 at 12:36 -0700, Paul E. McKenney wrote: > On Fri, Jun 08, 2007 at 11:27:08AM -0400, Steven Rostedt wrote: > > The first time I compiled it, I forgot the ';' and got a warning there. > > But the warning also included "declaring structure softirq_action in > > prototype", so I fix

Re: [PATCH RT] convert RCU Preempt tasklet into softirq.

2007-06-08 Thread Paul E. McKenney
On Fri, Jun 08, 2007 at 11:27:08AM -0400, Steven Rostedt wrote: > On Thu, 2007-06-07 at 14:02 -0700, Paul E. McKenney wrote: > > > Some nits below. > > > > Thanx, Paul > > > > > Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> > > > > > > Index: linu

Re: [PATCH RT] convert RCU Preempt tasklet into softirq.

2007-06-08 Thread Steven Rostedt
On Thu, 2007-06-07 at 14:02 -0700, Paul E. McKenney wrote: > Some nits below. > > Thanx, Paul > > > Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> > > > > Index: linux-2.6.21-rt9/include/linux/rcupreempt.h > >

Re: [PATCH RT] convert RCU Preempt tasklet into softirq.

2007-06-08 Thread Paul E. McKenney
On Thu, Jun 07, 2007 at 09:16:51PM -0700, Paul E. McKenney wrote: > On Thu, Jun 07, 2007 at 04:16:09PM -0400, Steven Rostedt wrote: > > On Thu, 2007-06-07 at 14:51 -0400, Steven Rostedt wrote: > > > > > There might still be an issue here. With the patch I'm getting a really > > > slow response tim

Re: [PATCH RT] convert RCU Preempt tasklet into softirq.

2007-06-07 Thread Paul E. McKenney
On Thu, Jun 07, 2007 at 04:16:09PM -0400, Steven Rostedt wrote: > On Thu, 2007-06-07 at 14:51 -0400, Steven Rostedt wrote: > > > There might still be an issue here. With the patch I'm getting a really > > slow response time on networking. But that be because of other patches I > > have applied. >

Re: [PATCH RT] convert RCU Preempt tasklet into softirq.

2007-06-07 Thread Paul E. McKenney
On Thu, Jun 07, 2007 at 02:26:59PM -0400, Steven Rostedt wrote: > Following Dipankar's lead, I converted the tasklet in rcupreempt.c into > a softirq. > > I've compiled and booted with this patch, but ran no other tests. I should be able to run rcutorture on it. > Paul, I'm disappointed, this w

Re: [PATCH RT] convert RCU Preempt tasklet into softirq.

2007-06-07 Thread Steven Rostedt
On Thu, 2007-06-07 at 14:51 -0400, Steven Rostedt wrote: > There might still be an issue here. With the patch I'm getting a really > slow response time on networking. But that be because of other patches I > have applied. I removed this patch and I can still get the network slowdown/hang. So this

Re: [PATCH RT] convert RCU Preempt tasklet into softirq.

2007-06-07 Thread Steven Rostedt
On Thu, 2007-06-07 at 14:26 -0400, Steven Rostedt wrote: > Following Dipankar's lead, I converted the tasklet in rcupreempt.c into > a softirq. > > I've compiled and booted with this patch, but ran no other tests. There might still be an issue here. With the patch I'm getting a really slow respo

[PATCH RT] convert RCU Preempt tasklet into softirq.

2007-06-07 Thread Steven Rostedt
Following Dipankar's lead, I converted the tasklet in rcupreempt.c into a softirq. I've compiled and booted with this patch, but ran no other tests. Paul, I'm disappointed, this was so trivial I didn't get a chance to learn anything ;-) Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> Index: