Re: [PATCH RFC v2 2/2] media: platform: pxa_camera: make a standalone v4l2 device

2016-08-01 Thread Hans Verkuil
Hi Robert, On 07/31/2016 05:03 PM, Robert Jarzmik wrote: > Hi Hans, > > > Hans Verkuil writes: >> On 04/02/2016 04:26 PM, Robert Jarzmik wrote: >>> diff --git a/drivers/media/platform/soc_camera/pxa_camera.c >>> b/drivers/media/platform/soc_camera/pxa_camera.c >>> index b8dd878e98d6..30d266bba

Re: [PATCH RFC v2 2/2] media: platform: pxa_camera: make a standalone v4l2 device

2016-07-31 Thread Robert Jarzmik
Hi Hans, Hans Verkuil writes: > On 04/02/2016 04:26 PM, Robert Jarzmik wrote: >> diff --git a/drivers/media/platform/soc_camera/pxa_camera.c >> b/drivers/media/platform/soc_camera/pxa_camera.c >> index b8dd878e98d6..30d266bbab55 100644 >> --- a/drivers/media/platform/soc_camera/pxa_camera.c >>

Re: [PATCH RFC v2 2/2] media: platform: pxa_camera: make a standalone v4l2 device

2016-07-04 Thread Hans Verkuil
Hi Robert, Thanks for the patch! On 04/02/2016 04:26 PM, Robert Jarzmik wrote: > This patch removes the soc_camera API dependency from pxa_camera. > In the current status : > - all previously captures are working the same on pxa270 > - the s_crop() call was removed, judged not working >(see

[PATCH RFC v2 2/2] media: platform: pxa_camera: make a standalone v4l2 device

2016-04-02 Thread Robert Jarzmik
This patch removes the soc_camera API dependency from pxa_camera. In the current status : - all previously captures are working the same on pxa270 - the s_crop() call was removed, judged not working (see what happens soc_camera_s_crop() when get_crop() == NULL) - if the pixel clock is provide