Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-22 Thread Lina Iyer
On Fri, Oct 12 2018 at 11:25 -0600, Sudeep Holla wrote: On Fri, Oct 12, 2018 at 11:19:10AM -0600, Lina Iyer wrote: On Fri, Oct 12 2018 at 11:01 -0600, Sudeep Holla wrote: > On Fri, Oct 12, 2018 at 10:04:27AM -0600, Lina Iyer wrote: > > On Fri, Oct 12 2018 at 09:04 -0600, Sudeep Holla wrote: > >

Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-12 Thread Raju P L S S S N
On 10/12/2018 7:55 PM, Sudeep Holla wrote: On Thu, Oct 11, 2018 at 02:50:54AM +0530, Raju P.L.S.S.S.N wrote: Use cpu hotplug callback mechanism to attach/dettach the cpu in the cpu power domain. During cpu hotplug callback registration, the starting callback is invoked on all online cpus. So

Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-12 Thread Sudeep Holla
On Fri, Oct 12, 2018 at 11:19:10AM -0600, Lina Iyer wrote: > On Fri, Oct 12 2018 at 11:01 -0600, Sudeep Holla wrote: > > On Fri, Oct 12, 2018 at 10:04:27AM -0600, Lina Iyer wrote: > > > On Fri, Oct 12 2018 at 09:04 -0600, Sudeep Holla wrote: > > > > [...] > > > > Yes all these are fine but with mul

Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-12 Thread Lina Iyer
On Fri, Oct 12 2018 at 11:01 -0600, Sudeep Holla wrote: On Fri, Oct 12, 2018 at 10:04:27AM -0600, Lina Iyer wrote: On Fri, Oct 12 2018 at 09:04 -0600, Sudeep Holla wrote: [...] Yes all these are fine but with multiple power-domains/cluster, it's hard to determine the first CPU. You may be abl

Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-12 Thread Sudeep Holla
On Fri, Oct 12, 2018 at 10:04:27AM -0600, Lina Iyer wrote: > On Fri, Oct 12 2018 at 09:04 -0600, Sudeep Holla wrote: [...] > > Why does CPU going down says that another (screen - supposedly shared) > > resource needs to be relinquished ? Shouldn't display decide that on it's > > own ? I have no i

Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-12 Thread Sudeep Holla
On Fri, Oct 12, 2018 at 05:46:13PM +0200, Ulf Hansson wrote: [...] > > Apologize for sidetracking the discussion, just want to fold in a few > comments. > No need to apologize, you are just contributing to get better understanding of the system. > This is becoming a complicated story. May I sugg

Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-12 Thread Lina Iyer
On Fri, Oct 12 2018 at 09:46 -0600, Ulf Hansson wrote: On 12 October 2018 at 17:04, Sudeep Holla wrote: On Thu, Oct 11, 2018 at 03:06:09PM -0600, Lina Iyer wrote: On Thu, Oct 11 2018 at 11:37 -0600, Sudeep Holla wrote: [...] > > Is DDR managed by Linux ? I assumed it was handled by higher e

Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-12 Thread Lina Iyer
On Fri, Oct 12 2018 at 09:04 -0600, Sudeep Holla wrote: On Thu, Oct 11, 2018 at 03:06:09PM -0600, Lina Iyer wrote: On Thu, Oct 11 2018 at 11:37 -0600, Sudeep Holla wrote: [...] > > Is DDR managed by Linux ? I assumed it was handled by higher exception > levels. Can you give examples of resour

Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-12 Thread Ulf Hansson
On 12 October 2018 at 17:04, Sudeep Holla wrote: > On Thu, Oct 11, 2018 at 03:06:09PM -0600, Lina Iyer wrote: >> On Thu, Oct 11 2018 at 11:37 -0600, Sudeep Holla wrote: > [...] > >> > >> > Is DDR managed by Linux ? I assumed it was handled by higher exception >> > levels. Can you give examples of

Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-12 Thread Sudeep Holla
On Thu, Oct 11, 2018 at 03:06:09PM -0600, Lina Iyer wrote: > On Thu, Oct 11 2018 at 11:37 -0600, Sudeep Holla wrote: [...] > > > > Is DDR managed by Linux ? I assumed it was handled by higher exception > > levels. Can you give examples of resources used by CPU in this context. > > When CPU can be

Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-12 Thread Sudeep Holla
On Thu, Oct 11, 2018 at 02:50:54AM +0530, Raju P.L.S.S.S.N wrote: > Use cpu hotplug callback mechanism to attach/dettach the cpu in > the cpu power domain. During cpu hotplug callback registration, > the starting callback is invoked on all online cpus. So there is > no need to attach from device pr

Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-11 Thread Lina Iyer
On Thu, Oct 11 2018 at 11:37 -0600, Sudeep Holla wrote: On Thu, Oct 11, 2018 at 10:58:22AM -0600, Lina Iyer wrote: On Thu, Oct 11 2018 at 10:19 -0600, Sudeep Holla wrote: > On Thu, Oct 11, 2018 at 10:00:53AM -0600, Lina Iyer wrote: > > Sudeep, > > > > The CPU PD does not power off the domain fro

Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-11 Thread Sudeep Holla
On Thu, Oct 11, 2018 at 10:58:22AM -0600, Lina Iyer wrote: > On Thu, Oct 11 2018 at 10:19 -0600, Sudeep Holla wrote: > > On Thu, Oct 11, 2018 at 10:00:53AM -0600, Lina Iyer wrote: > > > Sudeep, > > > > > > The CPU PD does not power off the domain from Linux. That is done from > > > PSCI firmware (A

Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-11 Thread Lina Iyer
On Thu, Oct 11 2018 at 10:19 -0600, Sudeep Holla wrote: On Thu, Oct 11, 2018 at 10:00:53AM -0600, Lina Iyer wrote: Sudeep, The CPU PD does not power off the domain from Linux. That is done from PSCI firmware (ATF). These patches are doing the part that Linux has do, when powering off the CPUs,

Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-11 Thread Sudeep Holla
On Thu, Oct 11, 2018 at 10:00:53AM -0600, Lina Iyer wrote: > Sudeep, > > This is idea is based on GenPD/PM Domains, but solves for the CPU domain > activities that need to be done from Linux when the CPU domain could be > powered off. In that, it shares the same ideas from the series posted by > Ul

Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-11 Thread Lina Iyer
Sudeep, This is idea is based on GenPD/PM Domains, but solves for the CPU domain activities that need to be done from Linux when the CPU domain could be powered off. In that, it shares the same ideas from the series posted by Ulf. But this has no bearing on PSCI. The 845 SoC that Raju is working

Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-11 Thread Sudeep Holla
On Thu, Oct 11, 2018 at 02:50:54AM +0530, Raju P.L.S.S.S.N wrote: > Use cpu hotplug callback mechanism to attach/dettach the cpu in > the cpu power domain. During cpu hotplug callback registration, > the starting callback is invoked on all online cpus. So there is > no need to attach from device pr

[PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-10 Thread Raju P.L.S.S.S.N
Use cpu hotplug callback mechanism to attach/dettach the cpu in the cpu power domain. During cpu hotplug callback registration, the starting callback is invoked on all online cpus. So there is no need to attach from device probe. Signed-off-by: Raju P.L.S.S.S.N --- drivers/soc/qcom/cpu_pd.c | 3