Re: [PATCH RFC v1] clk: add gpio controlled clock multiplexer

2015-05-23 Thread Sergej Sawazki
Jyri, thanks for the review... On 22.05.2015 at 11:13 Jyri Sarha wrote: On 05/14/15 12:40, Sergej Sawazki wrote: +Optional properties: +- enable-gpios : GPIO reference for enabling and disabling the clock. I guess in theory you should not need the enable functionality here. You could just sta

Re: [PATCH RFC v1] clk: add gpio controlled clock multiplexer

2015-05-23 Thread Sergej Sawazki
Stephen, thanks for the review... On 21.05.2015 at 21:31 Stephen Boyd wrote: +static int clk_gpio_mux_set_parent(struct clk_hw *hw, u8 index) +{ + struct clk_gpio_mux *clk = to_clk_gpio_mux(hw); + + if (index > 1) + return -EINVAL; Doesn't seem possible if num_parents

Re: [PATCH RFC v1] clk: add gpio controlled clock multiplexer

2015-05-22 Thread Jyri Sarha
On 05/14/15 12:40, Sergej Sawazki wrote: Add a common clock driver for basic gpio controlled clock multiplexers. This driver can be used for devices like 5V41068A or 831721I from IDT or for discrete multiplexer circuits. The 'select' pin selects one of two parent clocks. The optional 'enable' pin

Re: [PATCH RFC v1] clk: add gpio controlled clock multiplexer

2015-05-21 Thread Stephen Boyd
On 05/14, Sergej Sawazki wrote: > diff --git a/drivers/clk/clk-gpio-mux.c b/drivers/clk/clk-gpio-mux.c > new file mode 100644 > index 000..9e41e92 > --- /dev/null > +++ b/drivers/clk/clk-gpio-mux.c [..] > +static int clk_gpio_mux_enable(struct clk_hw *hw) > +{ > + struct clk_gpio_mux *clk =

[PATCH RFC v1] clk: add gpio controlled clock multiplexer

2015-05-14 Thread Sergej Sawazki
Add a common clock driver for basic gpio controlled clock multiplexers. This driver can be used for devices like 5V41068A or 831721I from IDT or for discrete multiplexer circuits. The 'select' pin selects one of two parent clocks. The optional 'enable' pin can be used to enable or disable the clock