Re: [PATCH RFC V3 3/5] perf,tool: partial time support

2015-07-17 Thread Namhyung Kim
Hi, On Wed, Jul 15, 2015 at 07:03:38PM +, Liang, Kan wrote: > > However, perf_evlist__id_hdr_size() seems to be affected also. Are you > > sure it's okay too? > > > Yes. > id_hdr_size is calculated according to the first event. It impacts > perf tool generated COMM, MMAP and FORK events. >

RE: [PATCH RFC V3 3/5] perf,tool: partial time support

2015-07-15 Thread Liang, Kan
> > However, perf_evlist__id_hdr_size() seems to be affected also. Are you > sure it's okay too? > Yes. id_hdr_size is calculated according to the first event. It impacts perf tool generated COMM, MMAP and FORK events. But all of these events have same and position fixed IDENTIFIER, 0. When p

Re: [PATCH RFC V3 3/5] perf,tool: partial time support

2015-07-13 Thread Jiri Olsa
On Wed, Jul 08, 2015 at 04:44:55AM -0400, kan.li...@intel.com wrote: > From: Kan Liang > SNIP > + > + /* > + * Event parsing doesn't check the availability > + * Clear the bit which event parsing may be set. > + * Let following code check and reset if available > + * > +

Re: [PATCH RFC V3 3/5] perf,tool: partial time support

2015-07-13 Thread Jiri Olsa
he regular reference events. > This patchkit adds the ability to turn off time stamps per event. This > in term can reduce sampling overhead and the size of the perf.data. [PATCH RFC V3 3/5] perf,tool: partial time support for a minute I was wondering why's the patch not full and just

Re: [PATCH RFC V3 3/5] perf,tool: partial time support

2015-07-13 Thread Namhyung Kim
On Mon, Jul 13, 2015 at 07:01:51PM +, Liang, Kan wrote: > > On Wed, Jul 08, 2015 at 04:44:55AM -0400, kan.li...@intel.com wrote: > > > From: Kan Liang > > > > > > When multiple events are sampled it may not be needed to collect fine > > > grained time stamps on all events. The sample sites are

RE: [PATCH RFC V3 3/5] perf,tool: partial time support

2015-07-13 Thread Liang, Kan
> Hi, > > (CC-ing Adrian) > > On Wed, Jul 08, 2015 at 04:44:55AM -0400, kan.li...@intel.com wrote: > > From: Kan Liang > > > > When multiple events are sampled it may not be needed to collect fine > > grained time stamps on all events. The sample sites are usually nearby. > > It's enough to ha

Re: [PATCH RFC V3 3/5] perf,tool: partial time support

2015-07-13 Thread Namhyung Kim
Hi, (CC-ing Adrian) On Wed, Jul 08, 2015 at 04:44:55AM -0400, kan.li...@intel.com wrote: > From: Kan Liang > > When multiple events are sampled it may not be needed to collect fine > grained time stamps on all events. The sample sites are usually nearby. > It's enough to have time stamps on the

[PATCH RFC V3 3/5] perf,tool: partial time support

2015-07-08 Thread kan . liang
From: Kan Liang When multiple events are sampled it may not be needed to collect fine grained time stamps on all events. The sample sites are usually nearby. It's enough to have time stamps on the regular reference events. This patchkit adds the ability to turn off time stamps per event. This in