Re: [PATCH RFC 3/3] mtd: rawnand: Add support Macronix power down mode

2019-10-15 Thread masonccyang
Hi Miquel, > > > > > > > > + nand_select_target(chip, 0); > > > > > > > > > > On several NAND controllers there is no way to act on the CS line > > > > > without actually writing bytes to the NAND chip. So basically this > > > > > is very likely to not work. > > > > > > > > any other wa

Re: [PATCH RFC 3/3] mtd: rawnand: Add support Macronix power down mode

2019-10-15 Thread Miquel Raynal
Hi Mason, masonccy...@mxic.com.tw wrote on Tue, 15 Oct 2019 10:33:29 +0800: > Hi Boris, > > > > > > > + nand_select_target(chip, 0); > > > > > > > > On several NAND controllers there is no way to act on the CS line > > > > without actually writing bytes to the NAND chip. So basically thi

Re: [PATCH RFC 3/3] mtd: rawnand: Add support Macronix power down mode

2019-10-14 Thread masonccyang
Hi Boris, > > > > + nand_select_target(chip, 0); > > > > > > On several NAND controllers there is no way to act on the CS line > > > without actually writing bytes to the NAND chip. So basically this > > > is very likely to not work. > > > > any other way to make it work ? GPIO ? > > or

Re: [PATCH RFC 3/3] mtd: rawnand: Add support Macronix power down mode

2019-10-08 Thread Boris Brezillon
On Tue, 8 Oct 2019 10:06:50 +0800 masonccy...@mxic.com.tw wrote: > > > + nand_select_target(chip, 0); > > > > On several NAND controllers there is no way to act on the CS line > > without actually writing bytes to the NAND chip. So basically this > > is very likely to not work. > > any

Re: [PATCH RFC 3/3] mtd: rawnand: Add support Macronix power down mode

2019-10-07 Thread masonccyang
Hi Miquel, > > +int nand_power_down_op(struct nand_chip *chip) > > +{ > > + int ret; > > + > > + if (nand_has_exec_op(chip)) { > > + struct nand_op_instr instrs[] = { > > + NAND_OP_CMD(NAND_CMD_POWER_DOWN, 0), > > + }; > > + > > + struct nand_operation op = NAND_OPE

Re: [PATCH RFC 3/3] mtd: rawnand: Add support Macronix power down mode

2019-10-07 Thread Miquel Raynal
Hi Mason, Mason Yang wrote on Wed, 18 Sep 2019 15:56:26 +0800: > Macronix AD series support using power down command to > enter a minimum power consumption state. > > MTD default _suspend/_resume function replacement by > manufacturer postponed initialization. > > Signed-off-by: Mason Yang >

[PATCH RFC 3/3] mtd: rawnand: Add support Macronix power down mode

2019-09-18 Thread Mason Yang
Macronix AD series support using power down command to enter a minimum power consumption state. MTD default _suspend/_resume function replacement by manufacturer postponed initialization. Signed-off-by: Mason Yang --- drivers/mtd/nand/raw/nand_macronix.c | 78 +++