Re: [PATCH RFC 1/1] x86: fix bad memory access in fb_is_primary_device()

2016-03-31 Thread Ingo Molnar
* Alexander Popov wrote: > On 09.03.2016 15:46, Alexander Popov wrote: > > On 16.02.2016 18:18, Peter Jones wrote: > >> On Tue, Feb 16, 2016 at 01:49:18PM +, Matt Fleming wrote: > >>> [ Including Peter, the efifb maintainer. Original email is here, > >>> > >>> http://marc.info/?l=linux-k

Re: [PATCH RFC 1/1] x86: fix bad memory access in fb_is_primary_device()

2016-03-29 Thread Matt Fleming
On Tue, 29 Mar, at 12:53:47PM, Matt Fleming wrote: > On Fri, 25 Mar, at 02:29:21PM, Alexander Popov wrote: > > > > Excuse me, there is no reply for a long time. Did I touch any taboo topic? > > Hope to fix this bug. Thanks. > > Unless anyone complains soonish I'll send this to tip as part of the

Re: [PATCH RFC 1/1] x86: fix bad memory access in fb_is_primary_device()

2016-03-29 Thread Matt Fleming
On Fri, 25 Mar, at 02:29:21PM, Alexander Popov wrote: > > Excuse me, there is no reply for a long time. Did I touch any taboo topic? > Hope to fix this bug. Thanks. Unless anyone complains soonish I'll send this to tip as part of the EFI urgent queue.

Re: [PATCH RFC 1/1] x86: fix bad memory access in fb_is_primary_device()

2016-03-25 Thread Alexander Popov
On 09.03.2016 15:46, Alexander Popov wrote: > On 16.02.2016 18:18, Peter Jones wrote: >> On Tue, Feb 16, 2016 at 01:49:18PM +, Matt Fleming wrote: >>> [ Including Peter, the efifb maintainer. Original email is here, >>> >>> http://marc.info/?l=linux-kernel&m=145552936131335&w=2 >>> >>> I'

Re: [PATCH RFC 1/1] x86: fix bad memory access in fb_is_primary_device()

2016-03-09 Thread Alexander Popov
On 16.02.2016 18:18, Peter Jones wrote: > On Tue, Feb 16, 2016 at 01:49:18PM +, Matt Fleming wrote: >> [ Including Peter, the efifb maintainer. Original email is here, >> >> http://marc.info/?l=linux-kernel&m=145552936131335&w=2 >> >> I've snipped some of the quoted text ] >> >> On Tue, 1

Re: [PATCH RFC 1/1] x86: fix bad memory access in fb_is_primary_device()

2016-02-16 Thread Peter Jones
On Tue, Feb 16, 2016 at 01:49:18PM +, Matt Fleming wrote: > [ Including Peter, the efifb maintainer. Original email is here, > > http://marc.info/?l=linux-kernel&m=145552936131335&w=2 > > I've snipped some of the quoted text ] > > On Tue, 16 Feb, at 08:55:22AM, Ingo Molnar wrote: > >

Re: [PATCH RFC 1/1] x86: fix bad memory access in fb_is_primary_device()

2016-02-16 Thread Matt Fleming
[ Including Peter, the efifb maintainer. Original email is here, http://marc.info/?l=linux-kernel&m=145552936131335&w=2 I've snipped some of the quoted text ] On Tue, 16 Feb, at 08:55:22AM, Ingo Molnar wrote: > > (I've Cc:-ed the EFI-FB and FB gents. Mail quoted below.) > > * Alexander P

Re: [PATCH RFC 1/1] x86: fix bad memory access in fb_is_primary_device()

2016-02-15 Thread Ingo Molnar
(I've Cc:-ed the EFI-FB and FB gents. Mail quoted below.) * Alexander Popov wrote: > Currently the code in fb_is_primary_device() contains to_pci_dev() macro > which is applied to dev from struct fb_info. In some cases this causes > bad memory access when fb_is_primary_device() handles fb_info

[PATCH RFC 1/1] x86: fix bad memory access in fb_is_primary_device()

2016-02-15 Thread Alexander Popov
Currently the code in fb_is_primary_device() contains to_pci_dev() macro which is applied to dev from struct fb_info. In some cases this causes bad memory access when fb_is_primary_device() handles fb_info of efifb. The reason is that fb dev of efifb is embedded into struct platform_device but not