Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics data

2016-12-20 Thread Michal Hocko
On Tue 20-12-16 14:54:35, Mel Gorman wrote: > On Tue, Dec 20, 2016 at 03:35:02PM +0100, Michal Hocko wrote: > > On Tue 20-12-16 14:28:45, Mel Gorman wrote: > > > On Tue, Dec 20, 2016 at 02:26:43PM +0100, Michal Hocko wrote: > > > > On Tue 20-12-16 13:10:40, Mel Gorman wrote: > > > > > On Tue, Dec 2

Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics data

2016-12-20 Thread hejianet
On 20/12/2016 8:31 PM, Mel Gorman wrote: On Mon, Dec 12, 2016 at 01:59:07PM +0800, Jia He wrote: In commit b9f00e147f27 ("mm, page_alloc: reduce branches in zone_statistics"), it reconstructed codes to reduce the branch miss rate. Compared with the original logic, it assumed if !(flag & __GFP_

Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics data

2016-12-20 Thread hejianet
On 20/12/2016 5:18 PM, Michal Hocko wrote: On Mon 12-12-16 13:59:07, Jia He wrote: In commit b9f00e147f27 ("mm, page_alloc: reduce branches in zone_statistics"), it reconstructed codes to reduce the branch miss rate. Compared with the original logic, it assumed if !(flag & __GFP_OTHER_NODE)

Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics data

2016-12-20 Thread Vlastimil Babka
On 12/20/2016 10:18 AM, Michal Hocko wrote: > On Mon 12-12-16 13:59:07, Jia He wrote: >> In commit b9f00e147f27 ("mm, page_alloc: reduce branches in >> zone_statistics"), it reconstructed codes to reduce the branch miss rate. >> Compared with the original logic, it assumed if !(flag & __GFP_OTHER_N

Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics data

2016-12-20 Thread Mel Gorman
On Tue, Dec 20, 2016 at 03:35:02PM +0100, Michal Hocko wrote: > On Tue 20-12-16 14:28:45, Mel Gorman wrote: > > On Tue, Dec 20, 2016 at 02:26:43PM +0100, Michal Hocko wrote: > > > On Tue 20-12-16 13:10:40, Mel Gorman wrote: > > > > On Tue, Dec 20, 2016 at 10:18:14AM +0100, Michal Hocko wrote: > > >

Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics data

2016-12-20 Thread Vlastimil Babka
On 12/20/2016 03:35 PM, Michal Hocko wrote: > On Tue 20-12-16 14:28:45, Mel Gorman wrote: >> On Tue, Dec 20, 2016 at 02:26:43PM +0100, Michal Hocko wrote: >>> On Tue 20-12-16 13:10:40, Mel Gorman wrote: On Tue, Dec 20, 2016 at 10:18:14AM +0100, Michal Hocko wrote: > On Mon 12-12-16 13:59:0

Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics data

2016-12-20 Thread Mel Gorman
On Tue, Dec 20, 2016 at 02:28:45PM +, Mel Gorman wrote: > On Tue, Dec 20, 2016 at 02:26:43PM +0100, Michal Hocko wrote: > > On Tue 20-12-16 13:10:40, Mel Gorman wrote: > > > On Tue, Dec 20, 2016 at 10:18:14AM +0100, Michal Hocko wrote: > > > > On Mon 12-12-16 13:59:07, Jia He wrote: > > > > > I

Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics data

2016-12-20 Thread Michal Hocko
On Tue 20-12-16 14:28:45, Mel Gorman wrote: > On Tue, Dec 20, 2016 at 02:26:43PM +0100, Michal Hocko wrote: > > On Tue 20-12-16 13:10:40, Mel Gorman wrote: > > > On Tue, Dec 20, 2016 at 10:18:14AM +0100, Michal Hocko wrote: > > > > On Mon 12-12-16 13:59:07, Jia He wrote: > > > > > In commit b9f00e1

Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics data

2016-12-20 Thread Mel Gorman
On Tue, Dec 20, 2016 at 02:26:43PM +0100, Michal Hocko wrote: > On Tue 20-12-16 13:10:40, Mel Gorman wrote: > > On Tue, Dec 20, 2016 at 10:18:14AM +0100, Michal Hocko wrote: > > > On Mon 12-12-16 13:59:07, Jia He wrote: > > > > In commit b9f00e147f27 ("mm, page_alloc: reduce branches in > > > > zon

Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics data

2016-12-20 Thread Michal Hocko
On Tue 20-12-16 13:10:40, Mel Gorman wrote: > On Tue, Dec 20, 2016 at 10:18:14AM +0100, Michal Hocko wrote: > > On Mon 12-12-16 13:59:07, Jia He wrote: > > > In commit b9f00e147f27 ("mm, page_alloc: reduce branches in > > > zone_statistics"), it reconstructed codes to reduce the branch miss rate. >

Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics data

2016-12-20 Thread Mel Gorman
On Tue, Dec 20, 2016 at 10:18:14AM +0100, Michal Hocko wrote: > On Mon 12-12-16 13:59:07, Jia He wrote: > > In commit b9f00e147f27 ("mm, page_alloc: reduce branches in > > zone_statistics"), it reconstructed codes to reduce the branch miss rate. > > Compared with the original logic, it assumed if !

Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics data

2016-12-20 Thread Mel Gorman
On Mon, Dec 12, 2016 at 01:59:07PM +0800, Jia He wrote: > In commit b9f00e147f27 ("mm, page_alloc: reduce branches in > zone_statistics"), it reconstructed codes to reduce the branch miss rate. > Compared with the original logic, it assumed if !(flag & __GFP_OTHER_NODE) > z->node would not be equa

Re: [PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics data

2016-12-20 Thread Michal Hocko
On Mon 12-12-16 13:59:07, Jia He wrote: > In commit b9f00e147f27 ("mm, page_alloc: reduce branches in > zone_statistics"), it reconstructed codes to reduce the branch miss rate. > Compared with the original logic, it assumed if !(flag & __GFP_OTHER_NODE) > z->node would not be equal to preferred_z

[PATCH RFC 1/1] mm, page_alloc: fix incorrect zone_statistics data

2016-12-11 Thread Jia He
In commit b9f00e147f27 ("mm, page_alloc: reduce branches in zone_statistics"), it reconstructed codes to reduce the branch miss rate. Compared with the original logic, it assumed if !(flag & __GFP_OTHER_NODE) z->node would not be equal to preferred_zone->node. That seems to be incorrect. Fixes: c