Re: [PATCH RFC 0/4] static key support for error injection functions

2024-06-02 Thread Vlastimil Babka
On 6/2/24 10:47 PM, David Rientjes wrote: > On Fri, 31 May 2024, Vlastimil Babka wrote: > >> Patches 3 and 4 implement the static keys for the two mm fault injection >> sites in slab and page allocators. For a quick demonstration I've run a >> VM and the simple test from [1] that stresses the slab

Re: [PATCH RFC 0/4] static key support for error injection functions

2024-06-02 Thread David Rientjes
On Fri, 31 May 2024, Vlastimil Babka wrote: > Patches 3 and 4 implement the static keys for the two mm fault injection > sites in slab and page allocators. For a quick demonstration I've run a > VM and the simple test from [1] that stresses the slab allocator and got > this time before the series:

Re: [PATCH RFC 0/4] static key support for error injection functions

2024-06-02 Thread Wei Yang
On Fri, May 31, 2024 at 11:33:31AM +0200, Vlastimil Babka wrote: >Incomplete, help needed from ftrace/kprobe and bpf folks. > >As previously mentioned by myself [1] and others [2] the functions >designed for error injection can bring visible overhead in fastpaths >such as slab or page allocation, b

Re: [PATCH RFC 0/4] static key support for error injection functions

2024-06-01 Thread Vlastimil Babka
On 6/1/24 1:39 AM, Roman Gushchin wrote: > On Fri, May 31, 2024 at 11:33:31AM +0200, Vlastimil Babka wrote: >> Incomplete, help needed from ftrace/kprobe and bpf folks. >> >> As previously mentioned by myself [1] and others [2] the functions >> designed for error injection can bring visible overhe

Re: [PATCH RFC 0/4] static key support for error injection functions

2024-06-01 Thread Vlastimil Babka
On 5/31/24 5:31 PM, Mark Rutland wrote: > Hi, > > On Fri, May 31, 2024 at 11:33:31AM +0200, Vlastimil Babka wrote: >> Incomplete, help needed from ftrace/kprobe and bpf folks. > >> - the generic error injection using kretprobes with >> override_function_with_return is handled in patch 2. The >>

Re: [PATCH RFC 0/4] static key support for error injection functions

2024-05-31 Thread Roman Gushchin
On Fri, May 31, 2024 at 11:33:31AM +0200, Vlastimil Babka wrote: > Incomplete, help needed from ftrace/kprobe and bpf folks. > > As previously mentioned by myself [1] and others [2] the functions > designed for error injection can bring visible overhead in fastpaths > such as slab or page allocati

Re: [PATCH RFC 0/4] static key support for error injection functions

2024-05-31 Thread Mark Rutland
Hi, On Fri, May 31, 2024 at 11:33:31AM +0200, Vlastimil Babka wrote: > Incomplete, help needed from ftrace/kprobe and bpf folks. > - the generic error injection using kretprobes with > override_function_with_return is handled in patch 2. The > ALLOW_ERROR_INJECTION() annotation is extended so

[PATCH RFC 0/4] static key support for error injection functions

2024-05-31 Thread Vlastimil Babka
Incomplete, help needed from ftrace/kprobe and bpf folks. As previously mentioned by myself [1] and others [2] the functions designed for error injection can bring visible overhead in fastpaths such as slab or page allocation, because even if nothing hooks into them at a given moment, they are non