Re: [PATCH RFC 0/3] scsi: mpt: Refactor and port to dma_* interface

2020-09-17 Thread Martin K. Petersen
Alex, >> Have you tested your changes? > > No, as I'm afraid I don't have the hardware. QEMU supports it, I propose you try testing with that. I hesitate merging big changes to abandoned drivers unless they've been tested. It's too easy to miss things during review... -- Martin K. Petersen

Re: [PATCH RFC 0/3] scsi: mpt: Refactor and port to dma_* interface

2020-09-16 Thread Alex Dewar
On Tue, Sep 15, 2020 at 10:12:06PM -0400, Martin K. Petersen wrote: > > Alex, > > > Any feedback would be greatly appreciated! > > Have you tested your changes? No, as I'm afraid I don't have the hardware. For patch #1 though, I'm not sure that's such an issue, as the refactoring was really si

Re: [PATCH RFC 0/3] scsi: mpt: Refactor and port to dma_* interface

2020-09-15 Thread Martin K. Petersen
Alex, > Any feedback would be greatly appreciated! Have you tested your changes? -- Martin K. Petersen Oracle Linux Engineering

[PATCH RFC 0/3] scsi: mpt: Refactor and port to dma_* interface

2020-09-03 Thread Alex Dewar
Hi all, I started porting over the mpt code from using the old pci_* compat functions to their dma_* counterparts, but realised that there are many functions which have a sleepFlags argument, which is actually almost never actually needed: almost all of the functions are always called with sleepFl