Re: [PATCH RFC] virtio_pci: fix virtio spec compliance on restore

2014-09-24 Thread Amit Shah
On (Tue) 23 Sep 2014 [13:32:22], Michael S. Tsirkin wrote: > On restore, virtio pci does the following: > + set features > + init vqs etc - device can be used at this point! > + set ACKNOWLEDGE,DRIVER and DRIVER_OK status bits > > This is in violation of the virtio spec, which > requires the follo

Re: [PATCH RFC] virtio_pci: fix virtio spec compliance on restore

2014-09-24 Thread Michael S. Tsirkin
On Wed, Sep 24, 2014 at 02:27:27AM +0100, Ben Hutchings wrote: > On Tue, 2014-09-23 at 13:32 +0300, Michael S. Tsirkin wrote: > > On restore, virtio pci does the following: > > + set features > > + init vqs etc - device can be used at this point! > > + set ACKNOWLEDGE,DRIVER and DRIVER_OK status bi

Re: [PATCH RFC] virtio_pci: fix virtio spec compliance on restore

2014-09-23 Thread Ben Hutchings
On Tue, 2014-09-23 at 13:32 +0300, Michael S. Tsirkin wrote: > On restore, virtio pci does the following: > + set features > + init vqs etc - device can be used at this point! > + set ACKNOWLEDGE,DRIVER and DRIVER_OK status bits > > This is in violation of the virtio spec, which > requires the fol

Re: [PATCH RFC] virtio_pci: fix virtio spec compliance on restore

2014-09-23 Thread Michael S. Tsirkin
On Tue, Sep 23, 2014 at 09:06:03AM -0700, Eric Northup wrote: > On Tue, Sep 23, 2014 at 3:32 AM, Michael S. Tsirkin wrote: > > On restore, virtio pci does the following: > > + set features > > + init vqs etc - device can be used at this point! > > + set ACKNOWLEDGE,DRIVER and DRIVER_OK status bits

Re: [PATCH RFC] virtio_pci: fix virtio spec compliance on restore

2014-09-23 Thread Eric Northup
On Tue, Sep 23, 2014 at 3:32 AM, Michael S. Tsirkin wrote: > On restore, virtio pci does the following: > + set features > + init vqs etc - device can be used at this point! > + set ACKNOWLEDGE,DRIVER and DRIVER_OK status bits > > This is in violation of the virtio spec, which > requires the follo

[PATCH RFC] virtio_pci: fix virtio spec compliance on restore

2014-09-23 Thread Michael S. Tsirkin
On restore, virtio pci does the following: + set features + init vqs etc - device can be used at this point! + set ACKNOWLEDGE,DRIVER and DRIVER_OK status bits This is in violation of the virtio spec, which requires the following order: - ACKNOWLEDGE - DRIVER - init vqs - DRIVER_OK Cc: sta...@vge