Re: [PATCH RFC] sd: spin down disks on removal or power-down

2007-01-31 Thread Robert Hancock
Stefan Richter wrote: Robert Hancock wrote: http://marc.theaimsgroup.com/?t=11692262122 It looks like Tejun's patch essentially does the same thing as mine with the addition of the control from userspace. There is one exception though, my patch also does the stop on removal of the SCSI disk

Re: [PATCH RFC] sd: spin down disks on removal or power-down

2007-01-31 Thread Stefan Richter
Robert Hancock wrote: >> http://marc.theaimsgroup.com/?t=11692262122 > > It looks like Tejun's patch essentially does the same thing as mine with > the addition of the control from userspace. There is one exception > though, my patch also does the stop on removal of the SCSI disk (i.e. > writi

Re: [PATCH RFC] sd: spin down disks on removal or power-down

2007-01-29 Thread Robert Hancock
James Bottomley wrote: On Mon, 2007-01-29 at 15:47 -0800, Andrew Morton wrote: What we don't want to happen is for those disks to spin down during a reboot. It seems that this is OK with this patch. Also, we probably don't want them to be spun down during a kexec_load, but I expect that's OK to

Re: [PATCH RFC] sd: spin down disks on removal or power-down

2007-01-29 Thread James Bottomley
On Mon, 2007-01-29 at 15:47 -0800, Andrew Morton wrote: > What we don't want to happen is for those disks to spin down during a > reboot. > It seems that this is OK with this patch. > > Also, we probably don't want them to be spun down during a kexec_load, > but > I expect that's OK too. Actually

Re: [PATCH RFC] sd: spin down disks on removal or power-down

2007-01-29 Thread Robert Hancock
Andrew Morton wrote: triviata: --- linux-2.6.20-rc6nv/drivers/scsi/sd.c2007-01-28 17:00:00.0 -0600 +++ linux-2.6.20-rc6nvedit/drivers/scsi/sd.c2007-01-28 18:08:53.0 -0600 @@ -821,6 +821,39 @@ static int sd_sync_cache(struct scsi_dev return res; } +static

Re: [PATCH RFC] sd: spin down disks on removal or power-down

2007-01-29 Thread Andrew Morton
On Sun, 28 Jan 2007 19:47:27 -0600 Robert Hancock <[EMAIL PROTECTED]> wrote: > Here's a patch for sd.c I've cooked up which issues a START STOP UNIT > command to stop the drive when the SCSI disk is removed or the machine > is powered down. The rationale behind this is that apparently on many > dr

[PATCH RFC] sd: spin down disks on removal or power-down

2007-01-28 Thread Robert Hancock
Here's a patch for sd.c I've cooked up which issues a START STOP UNIT command to stop the drive when the SCSI disk is removed or the machine is powered down. The rationale behind this is that apparently on many drives, simply cutting power to the spinning disk forces it to do an emergency head par