Re: [PATCH RFC] sched/deadline: support dl task migrate during cpu hotplug

2014-11-04 Thread Wanpeng Li
Hi Juri, On 14/11/4 下午11:50, Juri Lelli wrote: Hi, On 04/11/14 15:46, Peter Zijlstra wrote: On Tue, Nov 04, 2014 at 09:30:46PM +0800, Wanpeng Li wrote: + if (!rq->online) { + struct rq *latest_rq = NULL; + int cpu; + u64 dmin = LONG_MAX; + + for_each_cpu(cpu, &p->cpus_allowed) + if (cpu_onli

Re: [PATCH RFC] sched/deadline: support dl task migrate during cpu hotplug

2014-11-04 Thread Juri Lelli
Hi, On 04/11/14 15:46, Peter Zijlstra wrote: > On Tue, Nov 04, 2014 at 09:30:46PM +0800, Wanpeng Li wrote: > > >> + if (!rq->online) { >> + struct rq *latest_rq = NULL; >> + int cpu; >> + u64 dmin = LONG_MAX; >> + >> + for_each_cpu(cpu, &p->cpus_allowed) >> + if (cpu_online(cpu) && >> + cpu_rq(c

Re: [PATCH RFC] sched/deadline: support dl task migrate during cpu hotplug

2014-11-04 Thread Peter Zijlstra
On Tue, Nov 04, 2014 at 09:30:46PM +0800, Wanpeng Li wrote: > + if (!rq->online) { > + struct rq *latest_rq = NULL; > + int cpu; > + u64 dmin = LONG_MAX; > + > + for_each_cpu(cpu, &p->cpus_allowed) > + if (cpu_online(cpu) && > + cpu_rq(cpu)->dl.earliest_dl.curr < dmin) { > + latest_rq = cpu_rq(cp

Re: [PATCH RFC] sched/deadline: support dl task migrate during cpu hotplug

2014-11-04 Thread Wanpeng Li
On 14/11/4 下午9:30, Wanpeng Li wrote: Hi Peter, On 14/11/4 下午6:10, Peter Zijlstra wrote: On Tue, Nov 04, 2014 at 04:23:45PM +0800, Wanpeng Li wrote: On Tue, Nov 04, 2014 at 09:32:25AM +0100, Peter Zijlstra wrote: On Tue, Nov 04, 2014 at 07:57:48AM +0800, Wanpeng Li wrote: On Mon, Nov 03, 2014

Re: [PATCH RFC] sched/deadline: support dl task migrate during cpu hotplug

2014-11-04 Thread Wanpeng Li
Hi Peter, On 14/11/4 下午6:10, Peter Zijlstra wrote: On Tue, Nov 04, 2014 at 04:23:45PM +0800, Wanpeng Li wrote: On Tue, Nov 04, 2014 at 09:32:25AM +0100, Peter Zijlstra wrote: On Tue, Nov 04, 2014 at 07:57:48AM +0800, Wanpeng Li wrote: On Mon, Nov 03, 2014 at 11:41:11AM +0100, Peter Zijlstra wr

Re: [PATCH RFC] sched/deadline: support dl task migrate during cpu hotplug

2014-11-04 Thread Wanpeng Li
On 14/11/4 下午6:10, Peter Zijlstra wrote: On Tue, Nov 04, 2014 at 04:23:45PM +0800, Wanpeng Li wrote: On Tue, Nov 04, 2014 at 09:32:25AM +0100, Peter Zijlstra wrote: On Tue, Nov 04, 2014 at 07:57:48AM +0800, Wanpeng Li wrote: On Mon, Nov 03, 2014 at 11:41:11AM +0100, Peter Zijlstra wrote: On

Re: [PATCH RFC] sched/deadline: support dl task migrate during cpu hotplug

2014-11-04 Thread Peter Zijlstra
On Tue, Nov 04, 2014 at 04:23:45PM +0800, Wanpeng Li wrote: > On Tue, Nov 04, 2014 at 09:32:25AM +0100, Peter Zijlstra wrote: > >On Tue, Nov 04, 2014 at 07:57:48AM +0800, Wanpeng Li wrote: > >> On Mon, Nov 03, 2014 at 11:41:11AM +0100, Peter Zijlstra wrote: > > > >> >On Fri, Oct 31, 2014 at 03:28:1

Re: [PATCH RFC] sched/deadline: support dl task migrate during cpu hotplug

2014-11-04 Thread Juri Lelli
Hi, On 04/11/14 08:23, Wanpeng Li wrote: > Hi Peter, > On Tue, Nov 04, 2014 at 09:32:25AM +0100, Peter Zijlstra wrote: >> On Tue, Nov 04, 2014 at 07:57:48AM +0800, Wanpeng Li wrote: >>> On Mon, Nov 03, 2014 at 11:41:11AM +0100, Peter Zijlstra wrote: >> On Fri, Oct 31, 2014 at 03:28:17PM +0800

Re: [PATCH RFC] sched/deadline: support dl task migrate during cpu hotplug

2014-11-04 Thread Wanpeng Li
Hi Peter, On Tue, Nov 04, 2014 at 09:32:25AM +0100, Peter Zijlstra wrote: >On Tue, Nov 04, 2014 at 07:57:48AM +0800, Wanpeng Li wrote: >> On Mon, Nov 03, 2014 at 11:41:11AM +0100, Peter Zijlstra wrote: > >> >On Fri, Oct 31, 2014 at 03:28:17PM +0800, Wanpeng Li wrote: >> >So what is wrong with makin

Re: [PATCH RFC] sched/deadline: support dl task migrate during cpu hotplug

2014-11-04 Thread Peter Zijlstra
On Tue, Nov 04, 2014 at 07:57:48AM +0800, Wanpeng Li wrote: > On Mon, Nov 03, 2014 at 11:41:11AM +0100, Peter Zijlstra wrote: > >On Fri, Oct 31, 2014 at 03:28:17PM +0800, Wanpeng Li wrote: > >So what is wrong with making dl_task_timer() deal with it? The timer > >will still fire on the correct tim

Re: [PATCH RFC] sched/deadline: support dl task migrate during cpu hotplug

2014-11-03 Thread Wanpeng Li
Hi Peter, On Mon, Nov 03, 2014 at 11:41:11AM +0100, Peter Zijlstra wrote: >On Fri, Oct 31, 2014 at 03:28:17PM +0800, Wanpeng Li wrote: >> Hi all, >> >> I observe that dl task can't be migrated to other cpus during cpu hotplug, >> in >> addition, task may/may not be running again if cpu is added

Re: [PATCH RFC] sched/deadline: support dl task migrate during cpu hotplug

2014-11-02 Thread Wanpeng Li
Hi Juri, On Fri, Oct 31, 2014 at 11:42:23AM +, Juri Lelli wrote: >Hi, > >On 31/10/14 07:28, Wanpeng Li wrote: >> Hi all, >> >> I observe that dl task can't be migrated to other cpus during cpu hotplug, >> in >> addition, task may/may not be running again if cpu is added back. The root >> ca

Re: [PATCH RFC] sched/deadline: support dl task migrate during cpu hotplug

2014-11-02 Thread Wanpeng Li
Hi Kirill, On Fri, Oct 31, 2014 at 12:20:29PM +0300, Kirill Tkhai wrote: >В Пт, 31/10/2014 в 15:28 +0800, Wanpeng Li пишет: >> Hi all, >> >> I observe that dl task can't be migrated to other cpus during cpu hotplug, >> in >> addition, task may/may not be running again if cpu is added back. The r

[PATCH RFC] sched/deadline: support dl task migrate during cpu hotplug

2014-10-31 Thread Wanpeng Li
Hi all, I observe that dl task can't be migrated to other cpus during cpu hotplug, in addition, task may/may not be running again if cpu is added back. The root cause which I found is that dl task will be throtted and removed from dl rq after comsuming all budget, which leads to stop task can'