Re: [PATCH RFC] net: vlan: reverse 4 bytes of vlan header when setting initial MTU

2019-10-21 Thread David Ahern
On 10/21/19 7:31 PM, Yunsheng Lin wrote: > Or we just leave it as it is, and expect user to manually configure the MTU > of vlan netdev to the MTU of thelower device minus vlan header when the > performace in the above case is a concern to user? > for now, I would think so. vlan on a vxlan device

Re: [PATCH RFC] net: vlan: reverse 4 bytes of vlan header when setting initial MTU

2019-10-21 Thread Yunsheng Lin
On 2019/10/22 7:27, Stephen Hemminger wrote: > On Mon, 21 Oct 2019 20:26:03 +0800 > Yunsheng Lin wrote: > >> Currently the MTU of vlan netdevice is set to the same MTU >> of the lower device, which requires the underlying device >> to handle it as the comment has indicated: >> >> /* need 4 b

Re: [PATCH RFC] net: vlan: reverse 4 bytes of vlan header when setting initial MTU

2019-10-21 Thread Yunsheng Lin
On 2019/10/21 22:46, David Laight wrote: > From: Yunsheng Lin >> Sent: 21 October 2019 13:26 >> Currently the MTU of vlan netdevice is set to the same MTU >> of the lower device, which requires the underlying device >> to handle it as the comment has indicated: >> >> /* need 4 bytes for extra

Re: [PATCH RFC] net: vlan: reverse 4 bytes of vlan header when setting initial MTU

2019-10-21 Thread Stephen Hemminger
On Mon, 21 Oct 2019 20:26:03 +0800 Yunsheng Lin wrote: > Currently the MTU of vlan netdevice is set to the same MTU > of the lower device, which requires the underlying device > to handle it as the comment has indicated: > > /* need 4 bytes for extra VLAN header info, >* hope the u

RE: [PATCH RFC] net: vlan: reverse 4 bytes of vlan header when setting initial MTU

2019-10-21 Thread David Laight
From: Yunsheng Lin > Sent: 21 October 2019 13:26 > Currently the MTU of vlan netdevice is set to the same MTU > of the lower device, which requires the underlying device > to handle it as the comment has indicated: > > /* need 4 bytes for extra VLAN header info, >* hope the underlyin

[PATCH RFC] net: vlan: reverse 4 bytes of vlan header when setting initial MTU

2019-10-21 Thread Yunsheng Lin
Currently the MTU of vlan netdevice is set to the same MTU of the lower device, which requires the underlying device to handle it as the comment has indicated: /* need 4 bytes for extra VLAN header info, * hope the underlying device can handle it. */ new_dev->mtu