Re: [PATCH RFC] mm: vmalloc: do not allow kzalloc to fail

2018-12-24 Thread Nicholas Mc Guire
On Mon, Dec 24, 2018 at 10:38:04AM +0100, Nicholas Mc Guire wrote: > On Mon, Dec 24, 2018 at 09:10:56AM +0100, Michal Hocko wrote: > > On Sat 22-12-18 09:04:21, Nicholas Mc Guire wrote: > > > On Fri, Dec 21, 2018 at 01:58:39PM -0800, David Rientjes wrote: > > > > On Thu, 20 Dec 2018, Nicholas Mc Gu

Re: [PATCH RFC] mm: vmalloc: do not allow kzalloc to fail

2018-12-24 Thread Nicholas Mc Guire
On Mon, Dec 24, 2018 at 09:10:56AM +0100, Michal Hocko wrote: > On Sat 22-12-18 09:04:21, Nicholas Mc Guire wrote: > > On Fri, Dec 21, 2018 at 01:58:39PM -0800, David Rientjes wrote: > > > On Thu, 20 Dec 2018, Nicholas Mc Guire wrote: > > > > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > > >

Re: [PATCH RFC] mm: vmalloc: do not allow kzalloc to fail

2018-12-24 Thread Michal Hocko
On Sat 22-12-18 09:04:21, Nicholas Mc Guire wrote: > On Fri, Dec 21, 2018 at 01:58:39PM -0800, David Rientjes wrote: > > On Thu, 20 Dec 2018, Nicholas Mc Guire wrote: > > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > > index 871e41c..1c118d7 100644 > > > --- a/mm/vmalloc.c > > > +++ b/mm/vmal

Re: [PATCH RFC] mm: vmalloc: do not allow kzalloc to fail

2018-12-22 Thread Nicholas Mc Guire
On Fri, Dec 21, 2018 at 01:58:39PM -0800, David Rientjes wrote: > On Thu, 20 Dec 2018, Nicholas Mc Guire wrote: > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > index 871e41c..1c118d7 100644 > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -1258,7 +1258,7 @@ void __init vmalloc_init(void) >

Re: [PATCH RFC] mm: vmalloc: do not allow kzalloc to fail

2018-12-21 Thread David Rientjes
On Thu, 20 Dec 2018, Nicholas Mc Guire wrote: > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 871e41c..1c118d7 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -1258,7 +1258,7 @@ void __init vmalloc_init(void) > > /* Import existing vmlist entries. */ > for (tmp = vmlist; tmp

Re: [PATCH RFC] mm: vmalloc: do not allow kzalloc to fail

2018-12-21 Thread Michal Hocko
On Thu 20-12-18 21:23:57, Nicholas Mc Guire wrote: > While this is in a very early stage of the system boot and if memory > were exhausted the system has a more serious problem anyway - but still > the kzalloc here seems unsafe. Looking at the history it was previously > switched from alloc_bootmem

[PATCH RFC] mm: vmalloc: do not allow kzalloc to fail

2018-12-20 Thread Nicholas Mc Guire
While this is in a very early stage of the system boot and if memory were exhausted the system has a more serious problem anyway - but still the kzalloc here seems unsafe. Looking at the history it was previously switched from alloc_bootmem() to kzalloc() using GFP_NOWAIT flag but there never seems