Re: [Cocci] [PATCH RFC] coccinelle: flag constants being passed for jiffies

2015-05-28 Thread Nicholas Mc Guire
On Thu, 28 May 2015, Julia Lawall wrote: > > > On Wed, 27 May 2015, Nicholas Mc Guire wrote: > > > schedule_timeout_* takes a jiffies value as timeout - passing in a constant > > makes the timeout HZ dependent which is wrong. Checking for contstants only > > yields many false positives so they

Re: [PATCH RFC] coccinelle: flag constants being passed for jiffies

2015-05-27 Thread Julia Lawall
On Wed, 27 May 2015, Nicholas Mc Guire wrote: > schedule_timeout_* takes a jiffies value as timeout - passing in a constant > makes the timeout HZ dependent which is wrong. Checking for contstants only > yields many false positives so they are filtered for digits only. A numeric > value of 1 is

[PATCH RFC] coccinelle: flag constants being passed for jiffies

2015-05-27 Thread Nicholas Mc Guire
schedule_timeout_* takes a jiffies value as timeout - passing in a constant makes the timeout HZ dependent which is wrong. Checking for contstants only yields many false positives so they are filtered for digits only. A numeric value of 1 is though commonly in use for "shortest possible delay" so t