Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-17 Thread Mark Brown
On Thu, May 16, 2013 at 11:55:45AM -0700, Sören Brinkmann wrote: > On Thu, May 16, 2013 at 06:26:05PM +0100, Mark Brown wrote: > > The binding should obviously be defined as a set of clocks rather than a > > single clock - something like how we specify regulators on PMICs > > probably makes sense.

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-16 Thread Sören Brinkmann
On Thu, May 16, 2013 at 06:26:05PM +0100, Mark Brown wrote: > On Thu, May 16, 2013 at 10:44:16AM -0400, Philip Balister wrote: > > On 05/16/2013 12:28 AM, Saravana Kannan wrote: > > > > Agreed. I was about to reply with exactly the same point. I haven't done > > > any UIO coding, but that device f

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-16 Thread Mark Brown
On Wed, May 15, 2013 at 09:23:03PM -0700, Saravana Kannan wrote: > On 05/11/2013 07:21 AM, Mark Brown wrote: > >It's much harder when it's in the standard kernel and there's no contact > >with some of the users. I've pushed back pretty strongly on some of > >your equivalent stuff for regulators f

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-16 Thread Mark Brown
On Thu, May 16, 2013 at 10:44:16AM -0400, Philip Balister wrote: > On 05/16/2013 12:28 AM, Saravana Kannan wrote: > > Agreed. I was about to reply with exactly the same point. I haven't done > > any UIO coding, but that device file will eventually have to be opened. > > Turn on the clocks in the o

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-16 Thread Philip Balister
On 05/16/2013 12:28 AM, Saravana Kannan wrote: > On 05/14/2013 09:46 PM, Mark Brown wrote: >> On Tue, May 14, 2013 at 02:09:47PM -0400, Philip Balister wrote: >> >>> First of all, the driver that loads the bitstream into the fpga >>> fabric does not know ANYTHING about what the bitstream does. So i

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-15 Thread Saravana Kannan
On 05/14/2013 09:46 PM, Mark Brown wrote: On Tue, May 14, 2013 at 02:09:47PM -0400, Philip Balister wrote: First of all, the driver that loads the bitstream into the fpga fabric does not know ANYTHING about what the bitstream does. So it cannot do any setup based on the contents of the file tha

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-15 Thread Saravana Kannan
On 05/11/2013 07:21 AM, Mark Brown wrote: On Fri, May 10, 2013 at 04:01:25PM -0700, Saravana Kannan wrote: On 05/10/2013 03:18 PM, Mike Turquette wrote: Guys please delete irrelevant context from replies... One way to do it is to introduce a new config option, CONFIG_COMMON_CLK_DEBUG_CONTROL

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-14 Thread Mark Brown
On Tue, May 14, 2013 at 02:09:47PM -0400, Philip Balister wrote: > First of all, the driver that loads the bitstream into the fpga > fabric does not know ANYTHING about what the bitstream does. So it > cannot do any setup based on the contents of the file that is > loaded. (And this can also be lo

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-14 Thread Philip Balister
On 05/14/2013 12:46 PM, Mike Turquette wrote: Quoting Sören Brinkmann (2013-05-13 10:58:49) On Mon, May 13, 2013 at 07:37:23PM +0200, Sebastian Hesselbarth wrote: On 05/13/13 19:24, Sören Brinkmann wrote: On Mon, May 13, 2013 at 06:21:13PM +0200, Sebastian Hesselbarth wrote: Well, that driver

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-14 Thread Mike Turquette
Quoting Sören Brinkmann (2013-05-13 10:58:49) > On Mon, May 13, 2013 at 07:37:23PM +0200, Sebastian Hesselbarth wrote: > > On 05/13/13 19:24, Sören Brinkmann wrote: > > >On Mon, May 13, 2013 at 06:21:13PM +0200, Sebastian Hesselbarth wrote: > > >>>Well, that driver actually exists. But that just pr

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-13 Thread Mark Brown
On Mon, May 13, 2013 at 08:20:18PM +0200, Sebastian Hesselbarth wrote: > On 05/13/13 20:16, Mark Brown wrote: > >Yup, that's part of it. Though I have to say that if all we can do is > >stuff a bitstream in there there is the question about how anything that > >does require a real driver gets tha

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-13 Thread Sebastian Hesselbarth
On 05/13/13 20:16, Mark Brown wrote: On Mon, May 13, 2013 at 06:21:13PM +0200, Sebastian Hesselbarth wrote: what Mark wants to point out is that you add fabric clocks to the Xilinx driver instead. This way, you will have user-space controllable clocks but only if you loaded the xilinx driver fir

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-13 Thread Sebastian Hesselbarth
On 05/13/13 19:58, Sören Brinkmann wrote: On Mon, May 13, 2013 at 07:37:23PM +0200, Sebastian Hesselbarth wrote: It is, as it will only expose clocks on Zynq and that's what Mark and Mike are worried about. Expose clocks to user space and you will have people mess with it for sure. Well, even i

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-13 Thread Mark Brown
On Mon, May 13, 2013 at 06:21:13PM +0200, Sebastian Hesselbarth wrote: > On 05/13/13 18:09, Sören Brinkmann wrote: > >Well, that driver actually exists. But that just programs a bitstream > >you give it to program. It does not know anything about the design it > >programs and cannot make any kind

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-13 Thread Sören Brinkmann
On Mon, May 13, 2013 at 07:37:23PM +0200, Sebastian Hesselbarth wrote: > On 05/13/13 19:24, Sören Brinkmann wrote: > >On Mon, May 13, 2013 at 06:21:13PM +0200, Sebastian Hesselbarth wrote: > >>>Well, that driver actually exists. But that just programs a bitstream > >>>you give it to program. It doe

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-13 Thread Sebastian Hesselbarth
On 05/13/13 19:24, Sören Brinkmann wrote: On Mon, May 13, 2013 at 06:21:13PM +0200, Sebastian Hesselbarth wrote: Well, that driver actually exists. But that just programs a bitstream you give it to program. It does not know anything about the design it programs and cannot make any kind of decisi

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-13 Thread Sören Brinkmann
On Mon, May 13, 2013 at 06:21:13PM +0200, Sebastian Hesselbarth wrote: > On 05/13/13 18:09, Sören Brinkmann wrote: > >On Mon, May 13, 2013 at 09:21:35AM +0400, Mark Brown wrote: > >>On Sun, May 12, 2013 at 12:05:04PM -0700, Sören Brinkmann wrote: > >>>On Sun, May 12, 2013 at 06:33:44PM +0400, Mark

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-13 Thread Sebastian Hesselbarth
On 05/13/13 18:09, Sören Brinkmann wrote: On Mon, May 13, 2013 at 09:21:35AM +0400, Mark Brown wrote: On Sun, May 12, 2013 at 12:05:04PM -0700, Sören Brinkmann wrote: On Sun, May 12, 2013 at 06:33:44PM +0400, Mark Brown wrote: No, there's no confusion here - the clocks that are being exposed t

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-13 Thread Sören Brinkmann
On Mon, May 13, 2013 at 09:21:35AM +0400, Mark Brown wrote: > On Sun, May 12, 2013 at 12:05:04PM -0700, Sören Brinkmann wrote: > > On Sun, May 12, 2013 at 06:33:44PM +0400, Mark Brown wrote: > > > > No, there's no confusion here - the clocks that are being exposed to > > > userspace are the clocks

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-13 Thread Peter De Schrijver
> >>> > >>> For debugging purposes, being able to change parents would be nice too. > >> This is difficult and I don't have a good solution for it, hence it's > >> missing. A clock consumer like a device driver or this driver, just > >> knows about it's input clock, but not about the topology furt

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-12 Thread Mark Brown
On Sun, May 12, 2013 at 12:05:04PM -0700, Sören Brinkmann wrote: > On Sun, May 12, 2013 at 06:33:44PM +0400, Mark Brown wrote: > > No, there's no confusion here - the clocks that are being exposed to > > userspace are the clocks which enter the FPGA. The driver or whatever > > that understands th

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-12 Thread Sören Brinkmann
On Sun, May 12, 2013 at 06:33:44PM +0400, Mark Brown wrote: > On Sat, May 11, 2013 at 09:54:22AM -0700, Sören Brinkmann wrote: > > On Fri, May 10, 2013 at 10:24:22PM +0100, Mark Brown wrote: > > > > For your use case should these things be exposed by the FPGA device > > > asking for that rather th

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-12 Thread Mark Brown
On Sat, May 11, 2013 at 09:54:22AM -0700, Sören Brinkmann wrote: > On Fri, May 10, 2013 at 10:24:22PM +0100, Mark Brown wrote: > > For your use case should these things be exposed by the FPGA device > > asking for that rather than by having the clocks available separately? > > Or is this part of t

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-11 Thread Sören Brinkmann
On Fri, May 10, 2013 at 10:24:22PM +0100, Mark Brown wrote: > On Fri, May 10, 2013 at 10:31:31AM -0700, Soren Brinkmann wrote: > > > +Example: > > + usclk: usclk { > > + compatible = "clk-userspace"; > > + clocks = <&foo 15>, <&bar>; > > + clock-count = <2>; > > +

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-11 Thread Mark Brown
On Fri, May 10, 2013 at 04:01:25PM -0700, Saravana Kannan wrote: > On 05/10/2013 03:18 PM, Mike Turquette wrote: Guys please delete irrelevant context from replies... > >One way to do it is to introduce a new config option, > >CONFIG_COMMON_CLK_DEBUG_CONTROL that would expose the controls for > >

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-11 Thread Mark Brown
On Fri, May 10, 2013 at 10:31:31AM -0700, Soren Brinkmann wrote: > +Example: > + usclk: usclk { > + compatible = "clk-userspace"; > + clocks = <&foo 15>, <&bar>; > + clock-count = <2>; > + }; This is clearly *very* Linux specific so needs to be a linux

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-10 Thread Sören Brinkmann
On Fri, May 10, 2013 at 04:25:45PM -0700, Saravana Kannan wrote: > On 05/10/2013 04:06 PM, Sören Brinkmann wrote: > >On Fri, May 10, 2013 at 04:01:25PM -0700, Saravana Kannan wrote: > >>On 05/10/2013 03:18 PM, Mike Turquette wrote: > > >>>I think that Soren wants something with a stable interface

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-10 Thread Saravana Kannan
On 05/10/2013 04:06 PM, Sören Brinkmann wrote: On Fri, May 10, 2013 at 04:01:25PM -0700, Saravana Kannan wrote: On 05/10/2013 03:18 PM, Mike Turquette wrote: I think that Soren wants something with a stable interface that he can use for his Zynq use case. Regarding that, why not write an act

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-10 Thread Sören Brinkmann
On Fri, May 10, 2013 at 03:18:10PM -0700, Mike Turquette wrote: > On Fri, May 10, 2013 at 11:49 AM, Emilio López wrote: > > Hi, > > > > El 10/05/13 15:15, Sören Brinkmann escribió: > >> Hi Emilio, > >> > >> On Fri, May 10, 2013 at 02:44:44PM -0300, Emilio López wrote: > >>> Hi, > >>> > >>> El 10/0

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-10 Thread Sören Brinkmann
On Fri, May 10, 2013 at 04:01:25PM -0700, Saravana Kannan wrote: > On 05/10/2013 03:18 PM, Mike Turquette wrote: > >On Fri, May 10, 2013 at 11:49 AM, Emilio López wrote: > >>Hi, > >> > >>El 10/05/13 15:15, Sören Brinkmann escribió: > >>>Hi Emilio, > >>> > >>>On Fri, May 10, 2013 at 02:44:44PM -030

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-10 Thread Saravana Kannan
On 05/10/2013 03:18 PM, Mike Turquette wrote: On Fri, May 10, 2013 at 11:49 AM, Emilio López wrote: Hi, El 10/05/13 15:15, Sören Brinkmann escribió: Hi Emilio, On Fri, May 10, 2013 at 02:44:44PM -0300, Emilio López wrote: Hi, El 10/05/13 14:31, Soren Brinkmann escribió: The userspace cloc

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-10 Thread Mike Turquette
On Fri, May 10, 2013 at 11:49 AM, Emilio López wrote: > Hi, > > El 10/05/13 15:15, Sören Brinkmann escribió: >> Hi Emilio, >> >> On Fri, May 10, 2013 at 02:44:44PM -0300, Emilio López wrote: >>> Hi, >>> >>> El 10/05/13 14:31, Soren Brinkmann escribió: The userspace clock driver can be used to

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-10 Thread Emilio López
Hi, El 10/05/13 15:15, Sören Brinkmann escribió: > Hi Emilio, > > On Fri, May 10, 2013 at 02:44:44PM -0300, Emilio López wrote: >> Hi, >> >> El 10/05/13 14:31, Soren Brinkmann escribió: >>> The userspace clock driver can be used to expose clock controls through >>> sysfs to userspace. The driver

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-10 Thread Sören Brinkmann
Hi Emilio, On Fri, May 10, 2013 at 02:44:44PM -0300, Emilio López wrote: > Hi, > > El 10/05/13 14:31, Soren Brinkmann escribió: > > The userspace clock driver can be used to expose clock controls through > > sysfs to userspace. The driver creates entries in /sys/class/clk. > > > > Signed-off-by:

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-10 Thread Sören Brinkmann
Hi Andy, first, can you please send plain text email? The formatting gets messed up a bit for me otherwise. On Fri, May 10, 2013 at 08:42:34PM +0300, Andy Shevchenko wrote: >10.5.2013 20.32 "Soren Brinkmann" kirjoitti: >> >> The userspace clock driver can be used to expose clock con

Re: [PATCH RFC] clk: Introduce userspace clock driver

2013-05-10 Thread Emilio López
Hi, El 10/05/13 14:31, Soren Brinkmann escribió: > The userspace clock driver can be used to expose clock controls through > sysfs to userspace. The driver creates entries in /sys/class/clk. > > Signed-off-by: Soren Brinkmann > --- > .../devicetree/bindings/clock/clk-userspace.txt| 7 + >

[PATCH RFC] clk: Introduce userspace clock driver

2013-05-10 Thread Soren Brinkmann
The userspace clock driver can be used to expose clock controls through sysfs to userspace. The driver creates entries in /sys/class/clk. Signed-off-by: Soren Brinkmann --- .../devicetree/bindings/clock/clk-userspace.txt| 7 + drivers/clk/Kconfig| 9 ++ dr