Re: [PATCH RFC] ARM: option for loading modules into vmalloc area

2014-11-19 Thread Nicolas Pitre
On Wed, 19 Nov 2014, Ard Biesheuvel wrote: > On 19 November 2014 18:12, Nicolas Pitre wrote: > > On Wed, 19 Nov 2014, Russell King - ARM Linux wrote: > > > >> On Wed, Nov 19, 2014 at 11:57:15AM -0500, Nicolas Pitre wrote: > >> > On Wed, 19 Nov 2014, Russell King - ARM Linux wrote: > >> > > I don'

Re: [PATCH RFC] ARM: option for loading modules into vmalloc area

2014-11-19 Thread Ard Biesheuvel
On 19 November 2014 18:12, Nicolas Pitre wrote: > On Wed, 19 Nov 2014, Russell King - ARM Linux wrote: > >> On Wed, Nov 19, 2014 at 11:57:15AM -0500, Nicolas Pitre wrote: >> > On Wed, 19 Nov 2014, Russell King - ARM Linux wrote: >> > > I don't think I ever did, because its pretty much impossible t

Re: [PATCH RFC] ARM: option for loading modules into vmalloc area

2014-11-19 Thread Nicolas Pitre
On Wed, 19 Nov 2014, Russell King - ARM Linux wrote: > On Wed, Nov 19, 2014 at 11:57:15AM -0500, Nicolas Pitre wrote: > > On Wed, 19 Nov 2014, Russell King - ARM Linux wrote: > > > I don't think I ever did, because its pretty much impossible to do as I > > > explained in a follow up to this thread

Re: [PATCH RFC] ARM: option for loading modules into vmalloc area

2014-11-19 Thread Russell King - ARM Linux
On Wed, Nov 19, 2014 at 11:57:15AM -0500, Nicolas Pitre wrote: > On Wed, 19 Nov 2014, Russell King - ARM Linux wrote: > > I don't think I ever did, because its pretty much impossible to do as I > > explained in a follow up to this thread. > > > > We _used_ to do this with the userspace insmod meth

Re: [PATCH RFC] ARM: option for loading modules into vmalloc area

2014-11-19 Thread Nicolas Pitre
On Wed, 19 Nov 2014, Russell King - ARM Linux wrote: > On Wed, Nov 19, 2014 at 05:38:57PM +0100, Ard Biesheuvel wrote: > > Numbers are disambiguated by the f and b suffixes, so they can be > > reused in the same .s file. So as long as you use a strictly numerical > > prefix, you can deal correctly

Re: [PATCH RFC] ARM: option for loading modules into vmalloc area

2014-11-19 Thread Nicolas Pitre
On Wed, 19 Nov 2014, Russell King - ARM Linux wrote: > On Wed, Nov 19, 2014 at 11:37:47AM -0500, Nicolas Pitre wrote: > > On Wed, 19 Nov 2014, Russell King - ARM Linux wrote: > > > Which is not a good idea either, because the compiler needs to know how > > > far away its own manually generated lit

Re: [PATCH RFC] ARM: option for loading modules into vmalloc area

2014-11-19 Thread Russell King - ARM Linux
On Wed, Nov 19, 2014 at 05:38:57PM +0100, Ard Biesheuvel wrote: > Numbers are disambiguated by the f and b suffixes, so they can be > reused in the same .s file. So as long as you use a strictly numerical > prefix, you can deal correctly with the case where, for instance, > do_div() is called twice

Re: [PATCH RFC] ARM: option for loading modules into vmalloc area

2014-11-19 Thread Russell King - ARM Linux
On Wed, Nov 19, 2014 at 11:37:47AM -0500, Nicolas Pitre wrote: > On Wed, 19 Nov 2014, Russell King - ARM Linux wrote: > > Which is not a good idea either, because the compiler needs to know how > > far away its own manually generated literal pool is from the instructions > > which reference it. Th

Re: [PATCH RFC] ARM: option for loading modules into vmalloc area

2014-11-19 Thread Russell King - ARM Linux
On Wed, Nov 19, 2014 at 05:25:41PM +0100, Ard Biesheuvel wrote: > On 19 November 2014 17:07, Russell King - ARM Linux > wrote: > > On Wed, Nov 19, 2014 at 05:02:40PM +0100, Ard Biesheuvel wrote: > > Which is not a good idea either, because the compiler needs to know how > > far away its own manual

Re: [PATCH RFC] ARM: option for loading modules into vmalloc area

2014-11-19 Thread Ard Biesheuvel
On 19 November 2014 17:37, Nicolas Pitre wrote: > On Wed, 19 Nov 2014, Russell King - ARM Linux wrote: > >> On Wed, Nov 19, 2014 at 05:02:40PM +0100, Ard Biesheuvel wrote: >> > On 19 November 2014 16:52, Konstantin Khlebnikov wrote: >> > > Do you mean ldr pc, =symbol ? >> > > >> > > In this case

Re: [PATCH RFC] ARM: option for loading modules into vmalloc area

2014-11-19 Thread Ard Biesheuvel
On 19 November 2014 17:32, Konstantin Khlebnikov wrote: > On Wed, Nov 19, 2014 at 7:25 PM, Ard Biesheuvel > wrote: >> On 19 November 2014 17:07, Russell King - ARM Linux >> wrote: >>> On Wed, Nov 19, 2014 at 05:02:40PM +0100, Ard Biesheuvel wrote: On 19 November 2014 16:52, Konstantin Khleb

Re: [PATCH RFC] ARM: option for loading modules into vmalloc area

2014-11-19 Thread Nicolas Pitre
On Wed, 19 Nov 2014, Russell King - ARM Linux wrote: > On Wed, Nov 19, 2014 at 05:02:40PM +0100, Ard Biesheuvel wrote: > > On 19 November 2014 16:52, Konstantin Khlebnikov wrote: > > > Do you mean ldr pc, =symbol ? > > > > > > In this case I get this error: > > > > > > /tmp/ccAHtONU.s: Assembler

Re: [PATCH RFC] ARM: option for loading modules into vmalloc area

2014-11-19 Thread Konstantin Khlebnikov
On Wed, Nov 19, 2014 at 7:25 PM, Ard Biesheuvel wrote: > On 19 November 2014 17:07, Russell King - ARM Linux > wrote: >> On Wed, Nov 19, 2014 at 05:02:40PM +0100, Ard Biesheuvel wrote: >>> On 19 November 2014 16:52, Konstantin Khlebnikov wrote: >>> > Do you mean ldr pc, =symbol ? >>> > >>> > In

Re: [PATCH RFC] ARM: option for loading modules into vmalloc area

2014-11-19 Thread Ard Biesheuvel
On 19 November 2014 17:07, Russell King - ARM Linux wrote: > On Wed, Nov 19, 2014 at 05:02:40PM +0100, Ard Biesheuvel wrote: >> On 19 November 2014 16:52, Konstantin Khlebnikov wrote: >> > Do you mean ldr pc, =symbol ? >> > >> > In this case I get this error: >> > >> > /tmp/ccAHtONU.s: Assembler

Re: [PATCH RFC] ARM: option for loading modules into vmalloc area

2014-11-19 Thread Russell King - ARM Linux
On Wed, Nov 19, 2014 at 05:02:40PM +0100, Ard Biesheuvel wrote: > On 19 November 2014 16:52, Konstantin Khlebnikov wrote: > > Do you mean ldr pc, =symbol ? > > > > In this case I get this error: > > > > /tmp/ccAHtONU.s: Assembler messages: > > /tmp/ccAHtONU.s:220: Error: invalid literal constant:

Re: [PATCH RFC] ARM: option for loading modules into vmalloc area

2014-11-19 Thread Ard Biesheuvel
On 19 November 2014 16:52, Konstantin Khlebnikov wrote: > On Wed, Nov 19, 2014 at 5:54 PM, Ard Biesheuvel > wrote: >> On 19 November 2014 14:40, Arnd Bergmann wrote: >>> On Tuesday 18 November 2014 21:13:56 Konstantin Khlebnikov wrote: On 2014-11-18 20:34, Russell King - ARM Linux wrote: >>

Re: [PATCH RFC] ARM: option for loading modules into vmalloc area

2014-11-19 Thread Konstantin Khlebnikov
On Wed, Nov 19, 2014 at 5:54 PM, Ard Biesheuvel wrote: > On 19 November 2014 14:40, Arnd Bergmann wrote: >> On Tuesday 18 November 2014 21:13:56 Konstantin Khlebnikov wrote: >>> On 2014-11-18 20:34, Russell King - ARM Linux wrote: >>> > On Tue, Nov 18, 2014 at 08:21:46PM +0400, Konstantin Khlebni

Re: [PATCH RFC] ARM: option for loading modules into vmalloc area

2014-11-19 Thread Ard Biesheuvel
On 19 November 2014 14:40, Arnd Bergmann wrote: > On Tuesday 18 November 2014 21:13:56 Konstantin Khlebnikov wrote: >> On 2014-11-18 20:34, Russell King - ARM Linux wrote: >> > On Tue, Nov 18, 2014 at 08:21:46PM +0400, Konstantin Khlebnikov wrote: >> >> Usually modules are loaded into small area p

Re: [PATCH RFC] ARM: option for loading modules into vmalloc area

2014-11-19 Thread Arnd Bergmann
On Tuesday 18 November 2014 21:13:56 Konstantin Khlebnikov wrote: > On 2014-11-18 20:34, Russell King - ARM Linux wrote: > > On Tue, Nov 18, 2014 at 08:21:46PM +0400, Konstantin Khlebnikov wrote: > >> Usually modules are loaded into small area prior to the kernel > >> text because they are linked w

Re: [PATCH RFC] ARM: option for loading modules into vmalloc area

2014-11-18 Thread Konstantin Khlebnikov
On 2014-11-18 20:34, Russell King - ARM Linux wrote: On Tue, Nov 18, 2014 at 08:21:46PM +0400, Konstantin Khlebnikov wrote: Usually modules are loaded into small area prior to the kernel text because they are linked with the kernel using short calls. Compile-time instrumentation like GCOV or KA

Re: [PATCH RFC] ARM: option for loading modules into vmalloc area

2014-11-18 Thread Russell King - ARM Linux
On Tue, Nov 18, 2014 at 08:21:46PM +0400, Konstantin Khlebnikov wrote: > Usually modules are loaded into small area prior to the kernel > text because they are linked with the kernel using short calls. > Compile-time instrumentation like GCOV or KASAN bloats code a lot, > and as a result huge modul

[PATCH RFC] ARM: option for loading modules into vmalloc area

2014-11-18 Thread Konstantin Khlebnikov
Usually modules are loaded into small area prior to the kernel text because they are linked with the kernel using short calls. Compile-time instrumentation like GCOV or KASAN bloats code a lot, and as a result huge modules no longer fit into reserved area. This patch adds option CONFIG_MODULES_USE